77535[BUGFIX] Verify early for valid auto redirect creation or slug update
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/redirects/Classes/Hooks/DataHandlerSlugUpdateHook.php+4 −1
- typo3/sysext/redirects/Classes/RedirectUpdate/SlugRedirectChangeItemFactory.php+17 −1
- typo3/sysext/redirects/Tests/Functional/RedirectUpdate/Fixtures/SysFolderAsRootPage.csvnew+3 −0
- typo3/sysext/redirects/Tests/Functional/RedirectUpdate/SlugRedirectChangeItemFactoryTest.phpnew+116 −0
- typo3/sysext/redirects/Tests/Functional/Service/SlugServiceTest.php2+5 −0
Review log 1317
-
Stefan Bürk uploaded patch set 1 01/23/23, 13:01
-
Stefan Bürk updated the commit message in patch set 2 01/23/23, 13:05
-
core-ci voted on patch set 1 V +1 01/23/23, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36465
-
Oli Bartsch commented on patch set 2 01/23/23, 13:20
Could we please cover this with a simple test? -
Stefan Bürk commented on patch set 2 CR -1 01/23/23, 13:32
Reply
will try ... -
core-ci voted on patch set 2 V +1 01/23/23, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36466
-
Stefan Bürk uploaded patch set 3
CR -1V +101/23/23, 14:10 -
Stefan Bürk commented on patch set 3 01/23/23, 14:17
Reply
Added some simple tests for the SlugRedirectChangeItemFactory to cover this. Decided against doing that in the SlugServiceTest class which is meant for directly testing the SlugService. However, SlugServiceTests does not really tests the "hook" itself in the complete working state. Added a @todo to the SlugServiceTest class that this should be changed or added as additional Hook tests. Had that on my todo list already to refactor the testing in ext:redirects a bit, and mabye that was the reason why not having tests for this bugfix in first place. So thank you for asking for them. Hope you are fine with these tests. -
core-ci voted on patch set 3 V +1 01/23/23, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36471
-
Christian Kuhn commented on patch set 3 01/23/23, 14:29
SlugServiceTest.php:39clumsy ;) -
Stefan Bürk commented on patch set 4
V +101/23/23, 15:11Published edit on patch set 3. -
core-ci voted on patch set 4 V +1 01/23/23, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36477
-
Christian Kuhn voted on patch set 4 V +1 CR +1 01/23/23, 17:36
-
Oli Bartsch voted on patch set 4 V +1 CR +1 01/23/23, 18:10
-
Stefan Bürk voted on patch set 4 V +2 CR +2 01/23/23, 18:10
-
Stefan Bürk merged patch set 5 01/23/23, 18:10