Review main Merged

77540[TASK] Deprecate PageRenderer::removeLineBreaksFromTemplate and usages

Anja Leichsenring CR +2 V +2 Normal +90 −0 updated 01/23/23, 19:34

Commit message

Removal of line breaks from a rendered template can be easily achieved
by using a code optimization tool like tidy. There is no need to
have such functionality in a modern codebase.

The variable and it's usages are relics from TYPO3 4.5 and can safely
be removed, because there are better options available nowadays.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 911

  1. Anja Leichsenring uploaded patch set 1 01/23/23, 18:24

  2. core-ci voted on patch set 1 V +1 01/23/23, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36487

  3. Christian Kuhn commented on patch set 1 V +1 CR +1 01/23/23, 18:49

    nice one.
  4. Stefan Bürk commented on patch set 1 01/23/23, 18:54

    PageRenderer.php:736

    I think this should be removed along with the deprecation removal in v13. Otherwise, if someone has remove link breaks enabled this would be a change in behaviour in debug mode instead of avoiding it.
  5. Christian Kuhn uploaded patch set 2 CR +1 V +1 01/23/23, 18:59

  6. Christian Kuhn commented on patch set 1 V +1 CR +1 01/23/23, 18:59

    PageRenderer.php:736 Reply

    Done
  7. Christian Kuhn voted on patch set 2 V +1 CR +1 01/23/23, 19:00

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 01/23/23, 19:01

  9. core-ci voted on patch set 2 V +1 01/23/23, 19:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36488

  10. Stefan Bürk voted on patch set 2 V +2 CR +2 01/23/23, 19:34

  11. Stefan Bürk merged patch set 3 01/23/23, 19:34