Review main Merged

7755[BUGFIX] tslib_pibase: Outdated PHPDoc comment for pi_loadLL()

Stefan Rotsch CR +2 V +2 Easy +6 −3 updated 06/03/13, 20:49

Commit message

The PHPDoc comment for function pi_loadLL() still refers to a
"locallang.php" file, but other file extensions are now in use

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
  • Verified V +2
    • Tolleiv Nietsch +2

Files 1

Review log 8

  1. Georg Ringer commented on patch set 1 03/05/12, 20:22

    Do not submit

    class.tslib_pibase.php:929

    this is wrong again as now xlf is used ;) as xml is also supported, maybe make a general "locallang.*" ?
  2. Tolleiv Nietsch uploaded patch set 3 03/05/12, 20:22

  3. Tolleiv Nietsch commented on patch set 3 V 0 03/05/12, 20:22

    by team member; Looks good to me, approved Just added 4.8 -- besides that Georgs vote is still valid...
  4. Georg Ringer uploaded patch set 2 03/05/12, 20:22

  5. Georg Ringer commented on patch set 2 03/05/12, 20:22

    Verified; Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 03/05/12, 20:22

  7. Mr. Jenkins commented on patch set 2 03/05/12, 20:22

  8. Tolleiv Nietsch merged patch set 3 03/05/12, 20:22