Review main Merged

77555[BUGFIX] Fix sqlite bigint from ext_tables.sql issue

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 01/24/23, 09:58

Commit message

Table sys_messenger_messages introduced with #97700
declares a bigint(20) as primary key in ext_tables.sql.

ext_tables.sql is essentially mysql syntax, the core
SchemaMigrator creates a doctrine object structure
from it, and struggles with bigint on sqlite, found
by a nightly test.

A simple fix is to declare a "casual" int(11), which
should be more than big enough for this table and
is in line with our other "uid" column primary keys
of other tables.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Susi Moog +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1012

  1. Christian Kuhn uploaded patch set 1 01/24/23, 08:07

  2. Susi Moog voted on patch set 1 CR +1 01/24/23, 08:14

  3. core-ci voted on patch set 1 V +1 01/24/23, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36510

  4. Christian Kuhn commented on patch set 1 CR -1 01/24/23, 08:18

    temp -1: waiting for nightly.
  5. Stefan Bürk voted on patch set 1 V +1 CR +1 01/24/23, 08:21

  6. Georg Ringer voted on patch set 1 CR -1 01/24/23, 08:37

  7. core-ci commented on patch set 1 01/24/23, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36511

  8. Christian Kuhn voted on patch set 1 V +1 CR +1 01/24/23, 08:41

  9. Anja Leichsenring commented on patch set 1 V +1 CR +1 01/24/23, 09:06

    that's the error? Bless the nightlies.
  10. Georg Ringer voted on patch set 1 CR +1 01/24/23, 09:47

  11. Christian Kuhn commented on patch set 1 V +2 CR +2 01/24/23, 09:58

    Thanks for quick reviews.
  12. Christian Kuhn merged patch set 2 01/24/23, 09:58