Review main Merged

77557[TASK] Cleanup various LanguageService-related code

Benni Mack CR +2 V +2 Easy +17 −18 updated 01/24/23, 09:18

Commit message

Over the past few commits, a lot of changes
happened with LanguageService-related code, mainly
to streamline the initialization and creation
of LanguageService code.

For this reason, various parts have now been sorted
out:
* Proper injection of Locales class
* Consistent usage of LanguageService->init()
* Avoid additional pageRendererSetupTrait call in LoginController
* Avoid using LanguageService->init() if Factory is used
* Leftover "ISOcode" value is removed

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 56

  1. Benni Mack uploaded patch set 1 01/24/23, 08:36

  2. core-ci voted on patch set 1 V +1 01/24/23, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36514

  3. Susi Moog voted on patch set 1 V +1 CR +1 01/24/23, 09:08

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 01/24/23, 09:18

  5. Benni Mack voted on patch set 1 V +2 CR +2 01/24/23, 09:18

  6. Benni Mack merged patch set 2 01/24/23, 09:18