Review main Merged

77559[BUGFIX] Prevent null pointer exception in BackendConfigurationManager

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 01/24/23, 12:52

Commit message

According to the code, $request might be NULL,
leading to a null pointer exception on calling
`getAttribute()`. This got noticed on following
CI run: https://git.typo3.org/typo3/CI/cms/-/jobs/1917011.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 78

  1. Oli Bartsch uploaded patch set 1 01/24/23, 12:14

  2. Benni Mack voted on patch set 1 CR +1 01/24/23, 12:19

  3. Oliver Klee voted on patch set 1 CR +1 01/24/23, 12:20

  4. core-ci voted on patch set 1 V +1 01/24/23, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36533

  5. Benni Mack voted on patch set 1 V +1 01/24/23, 12:27

  6. Andreas Kienast voted on patch set 1 V +1 CR +1 01/24/23, 12:50

  7. Stefan Bürk voted on patch set 1 V +2 CR +2 01/24/23, 12:52

  8. Stefan Bürk merged patch set 2 01/24/23, 12:52