Review main Merged

77566[TASK] Unify Labels for list view table header

Annett Jähnichen CR +2 V +2 Easy +6 −6 updated 01/24/23, 21:02

Commit message

Use only italic style for non sortable table cols.
Set 'Control' label to hidden in table header.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1012

  1. Annett Jähnichen uploaded patch set 1 01/24/23, 14:12

  2. core-ci voted on patch set 1 V +1 01/24/23, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36548

  3. Jasmina Ließmann voted on patch set 1 V +1 CR +1 01/24/23, 14:30

  4. Andreas Kienast commented on patch set 1 01/24/23, 14:59

    DatabaseRecordList.php:1183

    I think it'd make sense to remove the brackets in the "Show columns" selector as well.
  5. Annett Jähnichen uploaded patch set 2 CR +1 V +1 01/24/23, 15:12

  6. Annett Jähnichen commented on patch set 2 01/24/23, 15:15

    DatabaseRecordList.php:1183 Reply

    Yeah sure, I did that now too.
  7. core-ci voted on patch set 2 V +1 01/24/23, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36562

  8. Oli Bartsch commented on patch set 2 01/24/23, 15:23

    DatabaseRecordList.php:1183 Reply

    I do not agree on that. In the columns selector the brackets content are the corresponding field names, not the labels. This is especially useful for admins and in line with the the display in FormEngine etc.
  9. Oli Bartsch commented on patch set 2 01/24/23, 15:25

    DatabaseRecordList.php:1183 Reply

    Sorry, misunderstood your comment. You only removed the brackets around the labels, this is fine. :)
  10. Oli Bartsch voted on patch set 2 V +1 CR +1 01/24/23, 15:25

  11. Stefan Bürk voted on patch set 2 V +2 CR +2 01/24/23, 21:02

  12. Stefan Bürk merged patch set 3 01/24/23, 21:02