Review main Merged

77568[BUGFIX] Restore record date fields for all users

Oli Bartsch CR +2 V +2 Easy +9 −7 updated 01/25/23, 08:54

Commit message

Prior to the introduction of the column selector
in #84184, did a boolean flag "$addDateFields"
define whether record date fields (tstamp and
crdate) should be added to the available field list.

Actually, those fields were always added, because
all usages of the corresponding method set either
"$addDateFields" or "$dontCheckUser" to TRUE.

This fact is now restored by always adding the
mentioned fields.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Oli Bartsch uploaded patch set 1 01/24/23, 14:38

  2. Oli Bartsch uploaded patch set 2 01/24/23, 14:39

  3. Andreas Kienast voted on patch set 2 CR +1 01/24/23, 14:46

  4. core-ci voted on patch set 2 V +1 01/24/23, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36557

  5. core-ci voted on patch set 1 V +1 01/24/23, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36555

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 01/24/23, 23:52

  7. Andreas Kienast voted on patch set 2 V +1 01/25/23, 08:54

  8. Oli Bartsch voted on patch set 2 V +2 CR +2 01/25/23, 08:54

  9. Oli Bartsch merged patch set 3 01/25/23, 08:54