Review main Merged

77583Revert "[FEATURE] Add stdWrap to config.additionalHeaders"

Christian Kuhn CR +2 V +2 Easy +1 −40 updated 02/06/23, 21:11

Commit message

This reverts commit b8151562dc70330f1adfaf4ca56765d6eadc59a6.

Reason for revert:
Adding stdWrap to TS top-level 'config' object gives
headaches with fully-cached page access.
ContentObjectRenderer is not available in this context,
so COR->stdWrap() fails.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • Christoph Lehmann +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • Christoph Lehmann +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1113

  1. Christian Kuhn uploaded patch set 1 02/06/23, 20:55

  2. Christoph Lehmann commented on patch set 1 02/06/23, 20:57

    What's wrong with it?
  3. Christian Kuhn uploaded patch set 2 02/06/23, 20:59

  4. core-ci voted on patch set 1 V +1 02/06/23, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37222

  5. Nikita Hovratov voted on patch set 2 V +1 CR +1 02/06/23, 21:08

  6. core-ci voted on patch set 2 V +1 02/06/23, 21:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37224

  7. Anja Leichsenring voted on patch set 2 V +1 CR +1 02/06/23, 21:08

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 02/06/23, 21:08

  9. Oli Bartsch voted on patch set 2 V +1 CR +1 02/06/23, 21:08

  10. Christian Kuhn commented on patch set 2 V +1 CR +1 02/06/23, 21:09

    Reply

    COR is not available in fully-cache-page context.
  11. Christoph Lehmann voted on patch set 2 V +1 CR +1 02/06/23, 21:11

  12. Stefan Bürk voted on patch set 2 V +2 CR +2 02/06/23, 21:11

  13. Stefan Bürk merged patch set 3 02/06/23, 21:11