Review main Merged

77592[FEATURE] Add tile view to element browser

Benjamin Kott CR +2 V +2 Nightmare +2420 −1810 updated 04/11/23, 08:58

Commit message

The file list is the default implementation for TYPO3 to navigate and
manage assets. This patch extends the usage of the file list to the
element browser, the build-in component to select the assets for file
fields and folder fields in the backend.

The rendering of files and folder now deliver a unified experience and
allow the user to use the tile view to select assets.

The search within the file browser now respects the selected folder and
searches all subfolders for the provided search term.

To have a even more reliable experience, the user will now always start
the selection process in the root folder of the default storage.

Resource tiles are now adapting to the surrounding container instead of
the viewport, to make better use of the available space.

The file list now holds all related code to the file- and folderbrowser.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 45

Show 25 more files

Review log 5494

Show 3769 earlier messages
  1. Benjamin Kott uploaded patch set 1 01/24/23, 15:58

  2. core-ci voted on patch set 1 V -1 01/24/23, 16:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36564

  3. Benjamin Kott uploaded patch set 2 V -1 01/25/23, 15:43

  4. core-ci voted on patch set 2 V -1 01/25/23, 15:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36615

  5. Benjamin Kott uploaded patch set 3 V -1 01/26/23, 15:28

  6. core-ci voted on patch set 3 V -1 01/26/23, 15:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36657

  7. Benjamin Kott uploaded patch set 4 V -1 01/27/23, 11:39

  8. core-ci voted on patch set 4 V -1 01/27/23, 11:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36694

  9. Benjamin Kott uploaded patch set 5 V -1 01/27/23, 13:57

  10. core-ci voted on patch set 5 V -1 01/27/23, 14:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36696

  11. Benjamin Kott uploaded patch set 6 V -1 01/30/23, 15:40

  12. core-ci voted on patch set 6 V -1 01/30/23, 15:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36777

  13. Benjamin Kott uploaded patch set 7 V -1 01/31/23, 13:51

  14. Benjamin Kott uploaded patch set 8 01/31/23, 14:39

  15. core-ci voted on patch set 7 V -1 01/31/23, 14:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36824

  16. core-ci voted on patch set 8 V -1 01/31/23, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36826

  17. Benjamin Kott uploaded patch set 9 V -1 01/31/23, 15:46

  18. core-ci voted on patch set 9 V -1 01/31/23, 16:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36832

  19. Benni Mack commented on patch set 9 01/31/23, 22:20

    DropDownItemInterface.php:23

    I suggest to just implement \Stringable for all the other components (or just extend this one), maybe do this as a prepatch?

    SearchTermRestriction.php:72

    can you explain this? seems like a bugfix we could put into v11 as well
  20. Benjamin Kott uploaded patch set 10 V -1 02/01/23, 12:16

  21. core-ci voted on patch set 10 V -1 02/01/23, 12:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36868

  22. Benjamin Kott uploaded patch set 11 V -1 02/01/23, 15:42

  23. core-ci voted on patch set 11 V -1 02/01/23, 16:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36885

  24. Benjamin Kott uploaded patch set 12 V -1 02/02/23, 13:11

  25. core-ci voted on patch set 12 V -1 02/02/23, 14:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36924

  26. Benjamin Kott uploaded patch set 13 V -1 02/02/23, 15:03

  27. core-ci voted on patch set 13 V -1 02/02/23, 16:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36929

  28. Benjamin Kott uploaded patch set 14 V -1 02/03/23, 09:04

  29. core-ci voted on patch set 14 V -1 02/03/23, 09:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36966

  30. Benjamin Kott uploaded patch set 15 V -1 02/03/23, 09:25

  31. Benjamin Kott uploaded patch set 16 02/03/23, 09:31

  32. Michael Schams wrote 02/03/23, 09:42

    Removed cc Michael Schams.
  33. core-ci voted on patch set 15 V -1 02/03/23, 09:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36968

  34. core-ci voted on patch set 16 V -1 02/03/23, 10:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36970

  35. Benjamin Kott uploaded patch set 17 V -1 02/03/23, 14:05

  36. core-ci voted on patch set 17 V -1 02/03/23, 14:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36989

  37. Benjamin Kott uploaded patch set 18 V -1 02/03/23, 14:59

  38. Benjamin Kott uploaded patch set 19 02/03/23, 15:13

  39. core-ci voted on patch set 18 V -1 02/03/23, 15:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36992

  40. core-ci voted on patch set 19 V -1 02/03/23, 15:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36996

  41. Benjamin Kott uploaded patch set 20 V -1 02/06/23, 09:17

  42. Benjamin Kott uploaded patch set 21 02/06/23, 09:54

  43. core-ci voted on patch set 20 V -1 02/06/23, 10:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37145

  44. core-ci voted on patch set 21 V -1 02/06/23, 10:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37146

  45. Benjamin Kott uploaded patch set 22 V -1 02/06/23, 10:39

  46. core-ci voted on patch set 22 V -1 02/06/23, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37151

  47. Benjamin Kott uploaded patch set 23 V -1 02/06/23, 12:20

  48. Benjamin Kott uploaded patch set 24 02/06/23, 12:26

  49. core-ci voted on patch set 23 V -1 02/06/23, 12:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37157

  50. Benjamin Kott uploaded patch set 25 02/06/23, 12:50

  51. core-ci voted on patch set 24 V -1 02/06/23, 12:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37159

  52. Benjamin Kott uploaded patch set 26 02/06/23, 13:17

  53. core-ci voted on patch set 25 V +1 02/06/23, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37160

  54. Benjamin Kott uploaded patch set 27 02/06/23, 13:38

  55. Benjamin Kott uploaded patch set 28 02/06/23, 13:42

  56. core-ci voted on patch set 26 V -1 02/06/23, 13:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37161

  57. core-ci voted on patch set 27 V -1 02/06/23, 14:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37163

  58. core-ci voted on patch set 28 V -1 02/06/23, 14:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37164

  59. Benjamin Kott uploaded patch set 29 V -1 02/06/23, 14:16

  60. Benjamin Kott uploaded patch set 30 02/06/23, 14:21

  61. Benjamin Kott commented on patch set 30 02/06/23, 14:28

    DropDownItemInterface.php:23 Reply

    Done

    SearchTermRestriction.php:72 Reply

    not sure why it was needed, seems not to be necessary anymore.
  62. Benjamin Kott commented on patch set 30 02/06/23, 14:29

    SearchTermRestriction.php:72 Reply

    Done
  63. core-ci voted on patch set 30 V +1 02/06/23, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37170

  64. core-ci voted on patch set 29 V -1 02/06/23, 14:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37168

  65. Benjamin Kott uploaded patch set 31 V +1 02/06/23, 14:52

  66. core-ci voted on patch set 31 V -1 02/06/23, 15:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37172

  67. Benjamin Kott uploaded patch set 32 V -1 02/06/23, 15:10

  68. core-ci voted on patch set 32 V +1 02/06/23, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37174

  69. Benjamin Kott uploaded patch set 33 V +1 02/07/23, 08:13

  1. core-ci voted on patch set 33 V +1 02/07/23, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37257

  2. Benjamin Kott uploaded patch set 34 V +1 02/07/23, 08:22

  3. core-ci voted on patch set 34 V +1 02/07/23, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37258

  4. Benjamin Kott uploaded patch set 35 V +1 02/07/23, 14:24

  5. core-ci voted on patch set 35 V +1 02/07/23, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37292

  6. Andreas Kienast uploaded patch set 36 V +1 02/08/23, 09:54

  7. core-ci voted on patch set 36 V +1 02/08/23, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37347

  8. Andreas Kienast commented on patch set 36 V -1 02/08/23, 10:49

    I found two minor issues: * "Edit metadata" button is not enabled on selection * Drag&drop doesn't behave as before when attempting to drag a non-checked element I'll check whether I can solve both issues.
  9. Andreas Kienast uploaded patch set 37 V +1 02/08/23, 13:07

  10. core-ci voted on patch set 37 V +1 02/08/23, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37361

  11. Andreas Kienast voted on patch set 37 V +1 CR +1 02/08/23, 13:16

  12. Benjamin Kott uploaded patch set 38 CR +1 V +1 02/09/23, 07:27

  13. core-ci voted on patch set 38 V +1 02/09/23, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37425

  14. Andreas Kienast voted on patch set 38 V +1 CR +1 02/09/23, 07:38

  15. Benjamin Kott uploaded patch set 39 CR +1 V +1 02/10/23, 06:59

  16. Andreas Kienast voted on patch set 39 V +1 CR +1 02/10/23, 07:04

  17. core-ci voted on patch set 39 V +1 02/10/23, 07:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37521

  18. Benjamin Kott uploaded patch set 40 CR +1 V +1 02/10/23, 08:00

  19. Benjamin Kott commented on patch set 40 02/10/23, 08:01

    just removed a leftover not handled event
  20. core-ci voted on patch set 40 V +1 02/10/23, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37527

  21. Andreas Kienast voted on patch set 40 V +1 CR +1 02/10/23, 08:31

  22. Benni Mack voted on patch set 40 V +2 CR +2 02/10/23, 08:35

  23. Benni Mack merged patch set 41 02/10/23, 08:35

  24. Oliver Hader commented on patch set 41 02/10/23, 10:37

    FileList.php:619

    CSP violation...
  25. Oliver Hader commented on patch set 41 02/10/23, 10:43

    FileList.php:619 Reply Unresolved

    It currently works, since the event-listener is using `evt.preventDefault()`. However, then (listener in place) `href="#"` could be used as well.