77592[FEATURE] Add tile view to element browser
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 45
- Build/phpstan/phpstan-baseline.neon+0 −5
- Build/Sources/Sass/component/_resources.scss+15 −2
- Build/Sources/Sass/typo3/_main_form.scss+1 −1
- Build/Sources/TypeScript/backend/browse-files.tsdeleted+0 −100
- Build/Sources/TypeScript/backend/browse-folders.tsdeleted+0 −45
- Build/Sources/TypeScript/filelist/browse-files.tsnew+135 −0
- Build/Sources/TypeScript/filelist/browse-folders.tsnew+88 −0
- Build/Sources/TypeScript/filelist/file-delete.ts+5 −5
- Build/Sources/TypeScript/filelist/file-list-actions.tsnew+115 −0
- Build/Sources/TypeScript/filelist/file-list.ts+105 −98
- typo3/sysext/backend/Classes/ElementBrowser/FileBrowser.phpdeleted+0 −533
- typo3/sysext/backend/Classes/ElementBrowser/FolderBrowser.phpdeleted+0 −145
- typo3/sysext/backend/Configuration/Services.yaml+0 −6
- typo3/sysext/backend/Migrations/Code/ClassAliasMap.php+4 −2
- typo3/sysext/backend/Migrations/Code/LegacyClassesForIde.php+2 −2
- typo3/sysext/backend/Resources/Private/Templates/ElementBrowser/Folder.htmldeleted+0 −66
- typo3/sysext/backend/Resources/Public/Css/backend.css+16 −1
- typo3/sysext/backend/Resources/Public/JavaScript/browse-files.jsdeleted+0 −13
- typo3/sysext/backend/Resources/Public/JavaScript/browse-folders.jsdeleted+0 −13
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-99861-AddTileViewToElementBrowser.rstnew+36 −0
Show 25 more files
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileOperationsCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/InlineContentElementLocalizeSynchronizeCest.php+4 −4
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/InlinePagesLocalizeResourceCest.php+2 −2
- typo3/sysext/filelist/Classes/Controller/FileListController.php+3 −3
- typo3/sysext/filelist/Classes/Dto/ResourceView.php+119 −20
- typo3/sysext/filelist/Classes/Dto/UserPermissions.php+0 −1
- typo3/sysext/filelist/Classes/ElementBrowser/FileBrowser.phpnew+318 −0
- typo3/sysext/filelist/Classes/ElementBrowser/FolderBrowser.phpnew+282 −0
- typo3/sysext/filelist/Classes/Matcher/Matcher.phpnew+47 −0
- typo3/sysext/filelist/Classes/Matcher/MatcherInterface.phpnew+27 −0
- typo3/sysext/filelist/Classes/Matcher/ResourceFileExtensionMatcher.phpnew+92 −0
- typo3/sysext/filelist/Classes/Matcher/ResourceFileTypeMatcher.phpnew+37 −0
- typo3/sysext/filelist/Classes/Matcher/ResourceFolderTypeMatcher.phpnew+37 −0
- typo3/sysext/filelist/Classes/Type/Mode.phpnew+35 −0
- typo3/sysext/filelist/Classes/FileList.php2+789 −682
- typo3/sysext/filelist/Configuration/Services.yaml+6 −0
- typo3/sysext/filelist/Resources/Private/Templates/ElementBrowser/Files.htmlrenamed+4 −9
- typo3/sysext/filelist/Resources/Private/Templates/ElementBrowser/Folder.htmlcopied+4 −9
- typo3/sysext/filelist/Resources/Private/Templates/Filelist/List.html+8 −2
- typo3/sysext/filelist/Resources/Private/Templates/Filelist/Tiles.html+41 −37
- typo3/sysext/filelist/Resources/Public/JavaScript/browse-files.jsnew+13 −0
- typo3/sysext/filelist/Resources/Public/JavaScript/browse-folders.jsnew+13 −0
- typo3/sysext/filelist/Resources/Public/JavaScript/file-delete.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list-actions.jsnew+13 −0
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list.js+1 −1
Review log 5494
Show 3769 earlier messages
-
Benjamin Kott uploaded patch set 1 01/24/23, 15:58
-
core-ci voted on patch set 1 V -1 01/24/23, 16:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36564
-
Benjamin Kott uploaded patch set 2
V -101/25/23, 15:43 -
core-ci voted on patch set 2 V -1 01/25/23, 15:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36615
-
Benjamin Kott uploaded patch set 3
V -101/26/23, 15:28 -
core-ci voted on patch set 3 V -1 01/26/23, 15:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36657
-
Benjamin Kott uploaded patch set 4
V -101/27/23, 11:39 -
core-ci voted on patch set 4 V -1 01/27/23, 11:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36694
-
Benjamin Kott uploaded patch set 5
V -101/27/23, 13:57 -
core-ci voted on patch set 5 V -1 01/27/23, 14:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36696
-
Benjamin Kott uploaded patch set 6
V -101/30/23, 15:40 -
core-ci voted on patch set 6 V -1 01/30/23, 15:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36777
-
Benjamin Kott uploaded patch set 7
V -101/31/23, 13:51 -
Benjamin Kott uploaded patch set 8 01/31/23, 14:39
-
core-ci voted on patch set 7 V -1 01/31/23, 14:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36824
-
core-ci voted on patch set 8 V -1 01/31/23, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36826
-
Benjamin Kott uploaded patch set 9
V -101/31/23, 15:46 -
core-ci voted on patch set 9 V -1 01/31/23, 16:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36832
-
Benni Mack commented on patch set 9 01/31/23, 22:20
SearchTermRestriction.php:72can you explain this? seems like a bugfix we could put into v11 as well -
Benjamin Kott uploaded patch set 10
V -102/01/23, 12:16 -
core-ci voted on patch set 10 V -1 02/01/23, 12:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36868
-
Benjamin Kott uploaded patch set 11
V -102/01/23, 15:42 -
core-ci voted on patch set 11 V -1 02/01/23, 16:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36885
-
Benjamin Kott uploaded patch set 12
V -102/02/23, 13:11 -
core-ci voted on patch set 12 V -1 02/02/23, 14:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36924
-
Benjamin Kott uploaded patch set 13
V -102/02/23, 15:03 -
core-ci voted on patch set 13 V -1 02/02/23, 16:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36929
-
Benjamin Kott uploaded patch set 14
V -102/03/23, 09:04 -
core-ci voted on patch set 14 V -1 02/03/23, 09:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36966
-
Benjamin Kott uploaded patch set 15
V -102/03/23, 09:25 -
Benjamin Kott uploaded patch set 16 02/03/23, 09:31
-
Michael Schams wrote 02/03/23, 09:42
Removed cc Michael Schams. -
core-ci voted on patch set 15 V -1 02/03/23, 09:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36968
-
core-ci voted on patch set 16 V -1 02/03/23, 10:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36970
-
Benjamin Kott uploaded patch set 17
V -102/03/23, 14:05 -
core-ci voted on patch set 17 V -1 02/03/23, 14:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36989
-
Benjamin Kott uploaded patch set 18
V -102/03/23, 14:59 -
Benjamin Kott uploaded patch set 19 02/03/23, 15:13
-
core-ci voted on patch set 18 V -1 02/03/23, 15:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36992
-
core-ci voted on patch set 19 V -1 02/03/23, 15:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36996
-
Benjamin Kott uploaded patch set 20
V -102/06/23, 09:17 -
Benjamin Kott uploaded patch set 21 02/06/23, 09:54
-
core-ci voted on patch set 20 V -1 02/06/23, 10:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37145
-
core-ci voted on patch set 21 V -1 02/06/23, 10:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37146
-
Benjamin Kott uploaded patch set 22
V -102/06/23, 10:39 -
core-ci voted on patch set 22 V -1 02/06/23, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37151
-
Benjamin Kott uploaded patch set 23
V -102/06/23, 12:20 -
Benjamin Kott uploaded patch set 24 02/06/23, 12:26
-
core-ci voted on patch set 23 V -1 02/06/23, 12:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37157
-
Benjamin Kott uploaded patch set 25 02/06/23, 12:50
-
core-ci voted on patch set 24 V -1 02/06/23, 12:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37159
-
Benjamin Kott uploaded patch set 26 02/06/23, 13:17
-
core-ci voted on patch set 25 V +1 02/06/23, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37160
-
Benjamin Kott uploaded patch set 27 02/06/23, 13:38
-
Benjamin Kott uploaded patch set 28 02/06/23, 13:42
-
core-ci voted on patch set 26 V -1 02/06/23, 13:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37161
-
core-ci voted on patch set 27 V -1 02/06/23, 14:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37163
-
core-ci voted on patch set 28 V -1 02/06/23, 14:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37164
-
Benjamin Kott uploaded patch set 29
V -102/06/23, 14:16 -
Benjamin Kott uploaded patch set 30 02/06/23, 14:21
-
Benjamin Kott commented on patch set 30 02/06/23, 14:28
DropDownItemInterface.php:23ReplyDoneSearchTermRestriction.php:72Replynot sure why it was needed, seems not to be necessary anymore. -
Benjamin Kott commented on patch set 30 02/06/23, 14:29
SearchTermRestriction.php:72ReplyDone -
core-ci voted on patch set 30 V +1 02/06/23, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37170
-
core-ci voted on patch set 29 V -1 02/06/23, 14:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37168
-
Benjamin Kott uploaded patch set 31
V +102/06/23, 14:52 -
core-ci voted on patch set 31 V -1 02/06/23, 15:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37172
-
Benjamin Kott uploaded patch set 32
V -102/06/23, 15:10 -
core-ci voted on patch set 32 V +1 02/06/23, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37174
-
Benjamin Kott uploaded patch set 33
V +102/07/23, 08:13
-
core-ci voted on patch set 33 V +1 02/07/23, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37257
-
Benjamin Kott uploaded patch set 34
V +102/07/23, 08:22 -
core-ci voted on patch set 34 V +1 02/07/23, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37258
-
Benjamin Kott uploaded patch set 35
V +102/07/23, 14:24 -
core-ci voted on patch set 35 V +1 02/07/23, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37292
-
Andreas Kienast uploaded patch set 36
V +102/08/23, 09:54 -
core-ci voted on patch set 36 V +1 02/08/23, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37347
-
Andreas Kienast commented on patch set 36 V -1 02/08/23, 10:49
I found two minor issues: * "Edit metadata" button is not enabled on selection * Drag&drop doesn't behave as before when attempting to drag a non-checked element I'll check whether I can solve both issues. -
Andreas Kienast uploaded patch set 37
V +102/08/23, 13:07 -
core-ci voted on patch set 37 V +1 02/08/23, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37361
-
Andreas Kienast voted on patch set 37 V +1 CR +1 02/08/23, 13:16
-
Benjamin Kott uploaded patch set 38
CR +1V +102/09/23, 07:27 -
core-ci voted on patch set 38 V +1 02/09/23, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37425
-
Andreas Kienast voted on patch set 38 V +1 CR +1 02/09/23, 07:38
-
Benjamin Kott uploaded patch set 39
CR +1V +102/10/23, 06:59 -
Andreas Kienast voted on patch set 39 V +1 CR +1 02/10/23, 07:04
-
core-ci voted on patch set 39 V +1 02/10/23, 07:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37521
-
Benjamin Kott uploaded patch set 40
CR +1V +102/10/23, 08:00 -
Benjamin Kott commented on patch set 40 02/10/23, 08:01
just removed a leftover not handled event -
core-ci voted on patch set 40 V +1 02/10/23, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37527
-
Andreas Kienast voted on patch set 40 V +1 CR +1 02/10/23, 08:31
-
Benni Mack voted on patch set 40 V +2 CR +2 02/10/23, 08:35
-
Benni Mack merged patch set 41 02/10/23, 08:35
-
Oliver Hader commented on patch set 41 02/10/23, 10:37
FileList.php:619CSP violation... -
Oliver Hader commented on patch set 41 02/10/23, 10:43
FileList.php:619Reply UnresolvedIt currently works, since the event-listener is using `evt.preventDefault()`. However, then (listener in place) `href="#"` could be used as well.
DropDownItemInterface.php:23