Review main Merged

77593[BUGFIX] Fix PHP 8 warning in ContentObjectRenderer

Thomas Hohn CR +2 V +2 Easy +8 −2 updated 01/24/23, 20:51

Commit message

Since $conf['externalBlocks.'][$tagName . '.'] can be null, added a null
coalescing check to ensure that $cfg contains a valid value.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1217

  1. Thomas Hohn uploaded patch set 1 01/24/23, 17:38

  2. core-ci voted on patch set 1 V +1 01/24/23, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36567

  3. Oliver Klee updated the commit message in patch set 2 V +1 01/24/23, 17:58

  4. Oliver Klee voted on patch set 2 CR +1 01/24/23, 17:59

  5. core-ci voted on patch set 2 V +1 01/24/23, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36569

  6. Nikita Hovratov commented on patch set 2 01/24/23, 18:21

    ContentObjectRenderer.php:3115

    maybe we add this in addition to make it more clear? if ($tagName === '') { continue; } without a tagName the code below will never run. Same for the second one.
  7. Thomas Hohn commented on patch set 2 01/24/23, 18:41

    ContentObjectRenderer.php:3115 Reply

    I'm not sure if there is a condition where tagName is not '' and then $conf['externalBlocks.'][$tagName . '.'] will be null - maybe the commit message is misleading and should be "Since $conf['externalBlocks.'][$tagName . '.'] can be null, added a null coalescing check to ensure that $cfg contains a valid value." instead
  8. Thomas Hohn updated the commit message in patch set 3 CR +1 V +1 01/24/23, 18:45

  9. Thomas Hohn updated the commit message in patch set 4 01/24/23, 18:45

  10. Thomas Hohn commented on patch set 4 01/24/23, 18:47

    ContentObjectRenderer.php:3115 Reply

    Changed the commit message to reflect the real purpose of the change.
  11. Thomas Hohn uploaded patch set 5 01/24/23, 18:51

  12. core-ci voted on patch set 3 V +1 01/24/23, 18:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36570

  13. core-ci voted on patch set 4 V +1 01/24/23, 18:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36571

  14. core-ci voted on patch set 5 V +1 01/24/23, 19:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36572

  15. Nikita Hovratov commented on patch set 5 V +1 CR +1 01/24/23, 19:53

    Thanks!
  16. Stefan Bürk voted on patch set 5 V +2 CR +2 01/24/23, 20:51

  17. Stefan Bürk merged patch set 6 01/24/23, 20:51