Review main Merged

77594[TASK] Use explicit button labels in backend user module

Oli Bartsch CR +2 V +2 Normal +31 −25 updated 01/26/23, 13:56

Commit message

The backend user module contains of different
sub modules. All those sub modules contain a
"create new record" button in the doc header.
This button does now contain the actual record
to be created, instead of a general label.

Additionally does this patch add the missing
"resname" attribute to newly added locallang
labels and cleans up LocalizationUtility::translate()
usages in the BackendUserController.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Annett Jähnichen +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Annett Jähnichen +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 911

  1. Oli Bartsch uploaded patch set 1 01/24/23, 17:46

  2. core-ci voted on patch set 1 V +1 01/24/23, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36568

  3. Georg Ringer voted on patch set 1 CR +1 01/24/23, 20:39

  4. Christian Kuhn commented on patch set 1 CR -1 01/24/23, 23:50

    BackendUserController.php:171

    please avoid shortening the strings, use full file names: this makes locating label usages much easier and avoids extbase specific magic.
  5. Oli Bartsch uploaded patch set 2 CR +1 V +1 01/25/23, 07:39

  6. Oli Bartsch commented on patch set 2 01/25/23, 07:40

    BackendUserController.php:171 Reply

    Done
  7. core-ci voted on patch set 2 V +1 01/25/23, 07:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36596

  8. Andreas Kienast voted on patch set 2 V +1 CR +1 01/26/23, 08:09

  9. Annett Jähnichen commented on patch set 2 V +1 CR +1 01/26/23, 12:18

    Tested and looks good.
  10. Oli Bartsch voted on patch set 2 V +2 CR +2 01/26/23, 13:56

  11. Oli Bartsch merged patch set 3 01/26/23, 13:56