Review main Merged

77597[TASK] Remove "ISO 639-1" option from site configuration

Benni Mack CR +2 V +2 Hard +132 −143 updated 02/09/23, 19:53

Commit message

Due to the introduction of the unified
Locale class, the SiteLanguage now
resolves the two-letter-iso code from the
locale if it wasn't set before.

It is thus removed from the GUI when editing
or creating site languages, and also automatically
populated as fallback, however it is recommended
to fill the locale properly and the method
is deprecated.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 37

Show 17 more files

Review log 1730

Show 35 earlier messages
  1. Benni Mack uploaded patch set 1 01/24/23, 20:42

  2. core-ci voted on patch set 1 V -1 01/24/23, 21:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36577

  3. Benni Mack uploaded patch set 2 V -1 01/25/23, 07:35

  4. core-ci voted on patch set 2 V -1 01/25/23, 07:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36595

  5. Benni Mack uploaded patch set 3 V -1 01/25/23, 22:02

  1. core-ci voted on patch set 3 V -1 01/25/23, 22:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36632

  2. Benni Mack uploaded patch set 4 V -1 02/04/23, 21:57

  3. Benni Mack updated the commit message in patch set 5 02/04/23, 21:58

  4. core-ci voted on patch set 4 V -1 02/04/23, 22:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37073

  5. core-ci voted on patch set 5 V -1 02/04/23, 22:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37074

  6. Benni Mack uploaded patch set 6 V -1 02/04/23, 22:42

  7. core-ci voted on patch set 6 V -1 02/04/23, 23:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37083

  8. Benni Mack uploaded patch set 7 V -1 02/08/23, 16:46

  9. core-ci voted on patch set 7 V -1 02/08/23, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37391

  10. Benni Mack rebased onto patch set 8 V -1 02/09/23, 13:10

  11. core-ci voted on patch set 8 V -1 02/09/23, 13:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37452

  12. Benni Mack uploaded patch set 9 V -1 02/09/23, 14:47

  13. core-ci voted on patch set 9 V -1 02/09/23, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37476

  14. Benni Mack uploaded patch set 10 V -1 02/09/23, 15:11

  15. core-ci voted on patch set 10 V -1 02/09/23, 15:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37478

  16. Benni Mack uploaded patch set 11 V -1 02/09/23, 16:34

  17. Benni Mack uploaded patch set 12 02/09/23, 17:34

  18. core-ci voted on patch set 11 V -1 02/09/23, 17:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37482

  19. core-ci voted on patch set 12 V -1 02/09/23, 17:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37485

  20. Benni Mack uploaded patch set 13 V -1 02/09/23, 18:09

  21. core-ci voted on patch set 13 V +1 02/09/23, 18:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37488

  22. Georg Ringer voted on patch set 13 V +1 CR +1 02/09/23, 18:37

  23. Anja Leichsenring voted on patch set 13 V +1 CR +1 02/09/23, 19:20

  24. Benni Mack voted on patch set 13 V +2 CR +2 02/09/23, 19:53

  25. Benni Mack merged patch set 14 02/09/23, 19:53