77599[TASK] Improve "Active PageTsConfig" view
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Andreas Kienast +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 3
Files 41
- Build/Sources/Sass/typo3/_element_tree.scss+5 −0
- Build/Sources/TypeScript/backend/utility/collapse-state-persister.ts4+111 −33
- Build/Sources/TypeScript/backend/utility/collapse-state-search.tsnew+182 −0
- Build/Sources/TypeScript/backend/page-tsconfig.tsdeleted+0 −161
- typo3/sysext/adminpanel/Resources/Public/Css/adminpanel.css+1 −1
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigActiveController.php+187 −8
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+3 −1
- typo3/sysext/backend/Classes/ViewHelpers/TypoScript/FineDiffViewHelper.phprenamed+2 −2
- typo3/sysext/backend/Classes/ViewHelpers/HashViewHelper.phpdeleted+0 −42
- typo3/sysext/backend/Classes/ViewHelpers/IsArrayViewHelper.phpdeleted+0 −42
- typo3/sysext/backend/Configuration/Backend/Modules.php+4 −1
- typo3/sysext/backend/Resources/Private/Language/locallang_pagetsconfig.xlf+37 −4
- typo3/sysext/backend/Resources/Private/Partials/PageTsConfig/Tree.htmldeleted+0 −93
- typo3/sysext/backend/Resources/Private/Templates/PageTsConfig/Active.html+311 −15
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/utility/collapse-state-persister.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/utility/collapse-state-search.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/page-tsconfig.jsdeleted+0 −13
- typo3/sysext/core/Classes/TypoScript/AST/Node/AbstractChildNode.php+1 −1
- typo3/sysext/core/Classes/TypoScript/AST/Node/AbstractNode.php+21 −0
Show 21 more files
- typo3/sysext/core/Classes/TypoScript/AST/Node/NodeInterface.php+17 −2
- typo3/sysext/core/Classes/TypoScript/AST/Node/RootNode.php+8 −0
- typo3/sysext/core/Classes/TypoScript/AST/CommentAwareAstBuilder.php+2 −2
- typo3/sysext/core/Classes/TypoScript/PageTsConfigFactory.php+1 −0
- typo3/sysext/core/Tests/Acceptance/Application/Template/TemplateCest.php+0 −1
- typo3/sysext/core/Tests/Unit/TypoScript/AST/Node/ChildNodeTest.phpnew+67 −0
- typo3/sysext/core/Tests/Unit/TypoScript/AST/Node/ReferenceChildNodeTest.phpnew+66 −0
- typo3/sysext/core/Tests/Unit/TypoScript/AST/Node/RootNodeTest.phpnew+67 −0
- typo3/sysext/tstemplate/Classes/Controller/ConstantEditorController.php+13 −3
- typo3/sysext/tstemplate/Classes/Controller/InfoModifyController.php+13 −0
- typo3/sysext/tstemplate/Classes/Controller/ObjectBrowserController.php+21 −8
- typo3/sysext/tstemplate/Classes/Controller/TemplateAnalyzerController.php+6 −4
- typo3/sysext/tstemplate/Classes/Controller/TemplateRecordsOverviewController.php+13 −7
- typo3/sysext/tstemplate/Classes/ViewHelpers/ForViewHelper.phpdeleted+0 −53
- typo3/sysext/tstemplate/Resources/Private/Partials/AnalyzerConditions.html+2 −2
- typo3/sysext/tstemplate/Resources/Private/Partials/AnalyzerTree.html+104 −102
- typo3/sysext/tstemplate/Resources/Private/Partials/AnalyzerTreePanel.html+10 −9
- typo3/sysext/tstemplate/Resources/Private/Partials/ObjectBrowserConditions.html+6 −5
- typo3/sysext/tstemplate/Resources/Private/Partials/ObjectBrowserOptions.html+1 −1
- typo3/sysext/tstemplate/Resources/Private/Partials/ObjectBrowserTree.html+2 −1
- typo3/sysext/tstemplate/Resources/Private/Partials/ObjectBrowserTreePanel.html+1 −1
Review log 1931
Show 36 earlier messages
-
Christian Kuhn uploaded patch set 1 01/25/23, 04:02
-
core-ci voted on patch set 1 V -1 01/25/23, 04:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36591
-
Christian Kuhn uploaded patch set 2
V -101/25/23, 19:26 -
core-ci voted on patch set 2 V -1 01/25/23, 19:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36623
-
Christian Kuhn uploaded patch set 3
V -101/27/23, 10:29 -
core-ci voted on patch set 3 V -1 01/27/23, 10:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36685
-
Christian Kuhn uploaded patch set 4
V -101/27/23, 10:51 -
core-ci voted on patch set 4 V -1 01/27/23, 10:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36687
-
Christian Kuhn uploaded patch set 5
V -101/28/23, 14:23 -
core-ci voted on patch set 5 V -1 01/28/23, 14:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36714
-
Christian Kuhn uploaded patch set 6
V -101/29/23, 09:33 -
core-ci voted on patch set 6 V -1 01/29/23, 09:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36728
-
Christian Kuhn uploaded patch set 7
V -101/29/23, 11:22 -
Christian Kuhn uploaded patch set 8 01/29/23, 11:25
-
core-ci voted on patch set 7 V -1 01/29/23, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36729
-
core-ci voted on patch set 8 V -1 01/29/23, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36731
-
Christian Kuhn uploaded patch set 9
V -101/29/23, 11:58 -
Jasmina Ließmann wrote 01/29/23, 12:06
Removed cc Jasmina Ließmann. -
core-ci voted on patch set 9 V -1 01/29/23, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36732
-
Christian Kuhn uploaded patch set 10
V -101/30/23, 09:05 -
core-ci voted on patch set 10 V -1 01/30/23, 09:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36754
-
Christian Kuhn uploaded patch set 11
V -101/30/23, 11:07 -
Christian Kuhn uploaded patch set 12 01/30/23, 11:14
-
core-ci voted on patch set 11 V +1 01/30/23, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36756
-
Christian Kuhn updated the commit message in patch set 13 01/30/23, 11:15
-
core-ci voted on patch set 13 V +1 01/30/23, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36758
-
Nikita Hovratov voted on patch set 13 V +1 CR +1 01/30/23, 11:55
-
Andreas Kienast commented on patch set 13 01/30/23, 12:10
nitpicks onlycollapse-state-persister.ts:161```Client.unset(this.localStorageKey + suffix)``` should work as wellcollapse-state-persister.ts:169same here -
Christian Kuhn commented on patch set 13 01/30/23, 12:17
collapse-state-persister.ts:161ReplyThat would unset the entire thing, i want to unset a single key only?!collapse-state-persister.ts:169ReplyThat would unset the entire thing, i want to unset a single key only?! -
Andreas Kienast voted on patch set 13 V +2 CR +2 01/30/23, 12:54
-
Andreas Kienast merged patch set 14 01/30/23, 12:54