Review main Merged

77599[TASK] Improve "Active PageTsConfig" view

Christian Kuhn CR +2 V +2 Expert +1300 −620 updated 01/30/23, 12:54

Commit message

* Render "Available constants from site settings" if any
* Render used conditions if any
* Allow to show comments and constant substitutions
* Improve client side search
* Do not persist expand/collapse state when searching,
  to go back to previous expand/collapse state when
  clearing search term
* Codebase overhaul avoiding of intermediate view helpers
* Minor adaptions and cleanups in related modules

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 3

Files 41

Show 21 more files

Review log 1931

Show 36 earlier messages
  1. Christian Kuhn uploaded patch set 1 01/25/23, 04:02

  2. core-ci voted on patch set 1 V -1 01/25/23, 04:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36591

  3. Christian Kuhn uploaded patch set 2 V -1 01/25/23, 19:26

  4. core-ci voted on patch set 2 V -1 01/25/23, 19:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36623

  5. Christian Kuhn uploaded patch set 3 V -1 01/27/23, 10:29

  6. core-ci voted on patch set 3 V -1 01/27/23, 10:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36685

  1. Christian Kuhn uploaded patch set 4 V -1 01/27/23, 10:51

  2. core-ci voted on patch set 4 V -1 01/27/23, 10:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36687

  3. Christian Kuhn uploaded patch set 5 V -1 01/28/23, 14:23

  4. core-ci voted on patch set 5 V -1 01/28/23, 14:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36714

  5. Christian Kuhn uploaded patch set 6 V -1 01/29/23, 09:33

  6. core-ci voted on patch set 6 V -1 01/29/23, 09:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36728

  7. Christian Kuhn uploaded patch set 7 V -1 01/29/23, 11:22

  8. Christian Kuhn uploaded patch set 8 01/29/23, 11:25

  9. core-ci voted on patch set 7 V -1 01/29/23, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36729

  10. core-ci voted on patch set 8 V -1 01/29/23, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36731

  11. Christian Kuhn uploaded patch set 9 V -1 01/29/23, 11:58

  12. Jasmina Ließmann wrote 01/29/23, 12:06

    Removed cc Jasmina Ließmann.
  13. core-ci voted on patch set 9 V -1 01/29/23, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36732

  14. Christian Kuhn uploaded patch set 10 V -1 01/30/23, 09:05

  15. core-ci voted on patch set 10 V -1 01/30/23, 09:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36754

  16. Christian Kuhn uploaded patch set 11 V -1 01/30/23, 11:07

  17. Christian Kuhn uploaded patch set 12 01/30/23, 11:14

  18. core-ci voted on patch set 11 V +1 01/30/23, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36756

  19. Christian Kuhn updated the commit message in patch set 13 01/30/23, 11:15

  20. core-ci voted on patch set 13 V +1 01/30/23, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36758

  21. Nikita Hovratov voted on patch set 13 V +1 CR +1 01/30/23, 11:55

  22. Andreas Kienast commented on patch set 13 01/30/23, 12:10

    nitpicks only

    collapse-state-persister.ts:161

    ```Client.unset(this.localStorageKey + suffix)``` should work as well

    collapse-state-persister.ts:169

    same here
  23. Christian Kuhn commented on patch set 13 01/30/23, 12:17

    collapse-state-persister.ts:161 Reply

    That would unset the entire thing, i want to unset a single key only?!

    collapse-state-persister.ts:169 Reply

    That would unset the entire thing, i want to unset a single key only?!
  24. Andreas Kienast voted on patch set 13 V +2 CR +2 01/30/23, 12:54

  25. Andreas Kienast merged patch set 14 01/30/23, 12:54