Review main Merged

77602[FEATURE] Allow blinding site configuration options in configuration module

Eric Chavaillaz CR +2 V +2 Normal +106 −56 updated 01/27/23, 07:56

Commit message

This allows extensions to blind options from any site
configuration (YAML) in the configuration module. This
is achieved by dispatching the
ModifyBlindedConfigurationOptionsEvent, which got
introduced in #99717.

Additionaly, the PSR-14 Event is extended to provide
the identifier of the provider, dispatching the event.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 3

Files 9

Review log 1318

  1. Eric Chavaillaz uploaded patch set 1 01/25/23, 09:45

  2. core-ci voted on patch set 1 V +1 01/25/23, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36602

  3. Benni Mack commented on patch set 1 01/25/23, 11:42

    SitesYamlConfigurationProvider.php:34

    how about we use a PSR-14 event nowadays? we could also migrate the existing hook (used in the global variable provider) away. maybe event as a prepatch?
  4. Oli Bartsch commented on patch set 1 01/25/23, 12:22

    SitesYamlConfigurationProvider.php:34 Reply

    Good point. I will do a pre patch, adding a new PSR-14 event and deprecating the hook.
  5. Oli Bartsch commented on patch set 1 01/25/23, 14:20

    SitesYamlConfigurationProvider.php:34 Reply

  6. Oli Bartsch commented on patch set 1 CR -1 01/25/23, 16:16

    Let's wait for the new PSR-14 Event https://review.typo3.org/c/Packages/TYPO3.CMS/+/77606 to get merged.
  7. Eric Chavaillaz uploaded patch set 2 CR -1 V +1 01/26/23, 08:51

  8. core-ci voted on patch set 2 V +1 01/26/23, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36642

  9. Oli Bartsch uploaded patch set 3 V +1 01/26/23, 10:15

  10. Oli Bartsch commented on patch set 3 V +1 CR +1 01/26/23, 10:16

    Reply

    Done

    SitesYamlConfigurationProvider.php:34 Reply

    Done
  11. core-ci voted on patch set 3 V -1 01/26/23, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36645

  12. Oli Bartsch uploaded patch set 4 CR +1 V +1 01/26/23, 10:31

  13. core-ci voted on patch set 4 V +1 01/26/23, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36646

  14. Oli Bartsch uploaded patch set 5 V +1 01/26/23, 14:46

  15. Oli Bartsch voted on patch set 5 V +1 CR +1 01/26/23, 14:47

  16. core-ci voted on patch set 5 V +1 01/26/23, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36651

  17. Benni Mack voted on patch set 5 V +2 CR +2 01/27/23, 07:56

  18. Benni Mack merged patch set 6 01/27/23, 07:56