77602[FEATURE] Allow blinding site configuration options in configuration module
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 3
Files 9
- typo3/sysext/core/Documentation/Changelog/12.2/Feature-99717-NewPSR-14ModifyBlindedConfigurationOptionsEvent.rst+23 −10
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/GlobalVariableProvider.php+1 −1
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/SitesTcaConfigurationProvider.phprenamed+1 −1
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/SitesYamlConfiguration.phpdeleted+0 −38
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/SitesYamlConfigurationProvider.php4new+55 −0
- typo3/sysext/lowlevel/Classes/Event/ModifyBlindedConfigurationOptionsEvent.php+18 −2
- typo3/sysext/lowlevel/Configuration/Services.yaml+2 −2
- typo3/sysext/lowlevel/Tests/Functional/ConfigurationModuleProvider/GlobalVariableProviderTest.php+3 −1
- typo3/sysext/lowlevel/Tests/Unit/Event/ModifyBlindedConfigurationOptionsEventTest.php+3 −1
Review log 1318
-
Eric Chavaillaz uploaded patch set 1 01/25/23, 09:45
-
core-ci voted on patch set 1 V +1 01/25/23, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36602
-
Benni Mack commented on patch set 1 01/25/23, 11:42
-
Oli Bartsch commented on patch set 1 01/25/23, 12:22
SitesYamlConfigurationProvider.php:34ReplyGood point. I will do a pre patch, adding a new PSR-14 event and deprecating the hook. -
Oli Bartsch commented on patch set 1 01/25/23, 14:20
SitesYamlConfigurationProvider.php:34Reply -
Oli Bartsch commented on patch set 1 CR -1 01/25/23, 16:16
Let's wait for the new PSR-14 Event https://review.typo3.org/c/Packages/TYPO3.CMS/+/77606 to get merged. -
Eric Chavaillaz uploaded patch set 2
CR -1V +101/26/23, 08:51 -
core-ci voted on patch set 2 V +1 01/26/23, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36642
-
Oli Bartsch uploaded patch set 3
V +101/26/23, 10:15 -
Oli Bartsch commented on patch set 3 V +1 CR +1 01/26/23, 10:16
Reply
DoneSitesYamlConfigurationProvider.php:34ReplyDone -
core-ci voted on patch set 3 V -1 01/26/23, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36645
-
Oli Bartsch uploaded patch set 4
CR +1V +101/26/23, 10:31 -
core-ci voted on patch set 4 V +1 01/26/23, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36646
-
Oli Bartsch uploaded patch set 5
V +101/26/23, 14:46 -
Oli Bartsch voted on patch set 5 V +1 CR +1 01/26/23, 14:47
-
core-ci voted on patch set 5 V +1 01/26/23, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36651
-
Benni Mack voted on patch set 5 V +2 CR +2 01/27/23, 07:56
-
Benni Mack merged patch set 6 01/27/23, 07:56
SitesYamlConfigurationProvider.php:34