Review main Merged

77603[TASK] Use checkbox icons in ColumnSelector

Annett Jähnichen CR +2 V +2 Easy +2 −2 updated 01/30/23, 12:30

Commit message

Use checkbox icons instead of eye icon
to select show/hide columns in list view.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1014

  1. Annett Jähnichen uploaded patch set 1 01/25/23, 11:01

  2. Annett Jähnichen rebased onto patch set 2 01/25/23, 11:02

  3. core-ci voted on patch set 1 V +1 01/25/23, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36605

  4. core-ci voted on patch set 2 V +1 01/25/23, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36606

  5. Annett Jähnichen updated the commit message in patch set 3 V +1 01/25/23, 11:21

  6. core-ci voted on patch set 3 V +1 01/25/23, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36607

  7. Jörg Bösche voted on patch set 3 CR +1 01/27/23, 13:53

  8. Andreas Kienast commented on patch set 3 V -1 01/27/23, 14:55

    Since the new icons have a border, the UI looks weird in this context. Please see my comments for suggestions.

    ColumnSelector.html:55

    actions-check

    ColumnSelector.html:58

    miscellaneous-placeholder
  9. Annett Jähnichen uploaded patch set 4 CR +1 V +1 01/27/23, 17:16

  10. Annett Jähnichen commented on patch set 4 01/27/23, 17:18

    Reply

    Thx for your suggestions you are totally right. I used the appropriate icons. Looks much better.

    ColumnSelector.html:55 Reply

    Done

    ColumnSelector.html:58 Reply

    Done
  11. core-ci voted on patch set 4 V +1 01/27/23, 17:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36702

  12. Jasmina Ließmann voted on patch set 4 V +1 CR +1 01/28/23, 17:27

  13. Oli Bartsch voted on patch set 4 V +2 CR +2 01/30/23, 12:30

  14. Oli Bartsch merged patch set 5 01/30/23, 12:30