Review main Merged

77604[BUGFIX] Ensure module access flag is handled properly

Oli Bartsch CR +2 V +2 Easy +5 −5 updated 01/25/23, 12:19

Commit message

In case module access is restricted to "admin"
it's now ensured that the corresponding check
in the ModuleProvider fails for non-admin users.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Oli Bartsch uploaded patch set 1 01/25/23, 11:28

  2. core-ci voted on patch set 1 V +1 01/25/23, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36608

  3. Benni Mack voted on patch set 1 V +1 CR +1 01/25/23, 11:39

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 01/25/23, 11:52

  5. Oliver Klee voted on patch set 1 CR +1 01/25/23, 12:01

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 01/25/23, 12:19

  7. Oli Bartsch merged patch set 2 01/25/23, 12:19