Review main Merged

77605[BUGFIX] Set proper groups in AdminPanel

Achim Fritz CR +2 V +2 Easy +4 −0 updated 01/25/23, 16:28

Commit message

EXT:frontend's Preview simulation already sets the
userGroup values properly, which allows to simulate
a usergroup.

However, this change also needs to be set in EXT:adminpanel
in order to allow usergroups.

This change adds the same change (see #96381) as in
PreviewSimulator in EXT:adminpanel.

This is required as otherwise, the Frontend user would
re-set the userGroup in FrontendUserAuthentication->createUserAspect()

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1

Issues 2

Files 1

Review log 811

  1. Achim Fritz uploaded patch set 1 01/25/23, 14:17

  2. core-ci voted on patch set 1 V +1 01/25/23, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36612

  3. Benni Mack updated the commit message in patch set 2 V +1 01/25/23, 15:06

  4. Benni Mack wrote 01/25/23, 15:06

    Change destination moved from 11.5 to main
  5. Benni Mack voted on patch set 2 V +1 CR +1 01/25/23, 15:06

  6. core-ci voted on patch set 2 V +1 01/25/23, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36614

  7. Oli Bartsch updated the commit message in patch set 3 CR +1 V +1 01/25/23, 16:18

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 01/25/23, 16:19

  9. Benni Mack voted on patch set 3 V +2 CR +2 01/25/23, 16:25

  10. Benni Mack merged patch set 4 01/25/23, 16:25

  11. core-ci voted on patch set 3 V +1 01/25/23, 16:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36620