Review main Merged

77607[BUGFIX] Use correct language constraint in PageLayoutController

Oli Bartsch CR +2 V +2 Normal +35 −21 updated 01/26/23, 19:30

Commit message

When calculating the number of hidden elements for the
currently displayed language columns in the page module,
the corresponding language constraint is now properly set.

Considering more then one language is now only done,
in case language mode with a language > 0 is selected.

Additionally, L=-1 is now properly taken into account.

Some further cleanup of the method is done. The actually
defined field names of corresponding enable columns are
now used instead of the static ones.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Daniel Goerz +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Oli Bartsch uploaded patch set 1 01/25/23, 20:07

  2. core-ci voted on patch set 1 V +1 01/25/23, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36624

  3. Oli Bartsch uploaded patch set 2 V +1 01/25/23, 20:40

  4. core-ci voted on patch set 2 V +1 01/25/23, 20:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36625

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 01/26/23, 07:33

  6. Daniel Goerz voted on patch set 2 CR +1 01/26/23, 16:41

  7. Benni Mack voted on patch set 2 V +1 CR +1 01/26/23, 19:11

  8. Oli Bartsch voted on patch set 2 V +2 CR +2 01/26/23, 19:30

  9. Oli Bartsch merged patch set 3 01/26/23, 19:30