Review main Merged

77609[BUGFIX] Support embedding of private vimeo videos

Philipp Kitzberger CR +2 V +2 Easy +11 −3 updated 09/20/23, 14:30

Commit message

The video ID of a private vimeo video is appended
by a hash parameter. This tuple is stored in the
pseudo video file (*.vimeo) and needs to be respected
when rendering the iframe or fetching data via the
vimeo API.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 812

  1. Philipp Kitzberger uploaded patch set 1 01/26/23, 12:36

  2. core-ci voted on patch set 1 V -1 01/26/23, 12:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36647

  3. Philipp Kitzberger uploaded patch set 2 V -1 01/26/23, 14:57

  4. core-ci voted on patch set 2 V +1 01/26/23, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36653

  5. Benni Mack updated the commit message in patch set 3 V +1 05/03/23, 09:52

  6. Oli Bartsch uploaded patch set 4 09/20/23, 13:43

  7. Oli Bartsch updated the commit message in patch set 5 09/20/23, 13:45

  8. core-ci voted on patch set 4 V +1 09/20/23, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46887

  9. core-ci voted on patch set 5 V +1 09/20/23, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46888

  10. Oli Bartsch voted on patch set 5 V +1 CR +1 09/20/23, 14:06

  11. Stefan Bürk voted on patch set 5 V +2 CR +2 09/20/23, 14:20

  12. Stefan Bürk merged patch set 6 09/20/23, 14:30