Review main Merged

77611[TASK] Adjusting the appearance of the tables in the list module

Annett Jähnichen CR +2 V +2 Easy +10 −4 updated 02/06/23, 19:11

Commit message

To provide a streamlined look&feel of record tables in the record list,
their table header's background color now matches those of panels, e.g.
the "Clipboard" at the very bottom. For the same reason, a box-shadow is
applied.

To achieve a better visual separation, the table margin is increased.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2535

Show 710 earlier messages
  1. Annett Jähnichen uploaded patch set 1 01/26/23, 13:40

  2. core-ci voted on patch set 1 V +1 01/26/23, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36650

  3. Annett Jähnichen uploaded patch set 2 V +1 02/02/23, 11:55

  4. core-ci voted on patch set 2 V +1 02/02/23, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36920

  5. Jasmina Ließmann commented on patch set 2 02/03/23, 20:44

    I know it's still WIP, but I looked at the patch in the backend anyway. On pages/folders with many different data record types, the previous gray background helped with orientation and structuring of the data records. The white background makes the area and relation of the buttons more difficult to grasp. Maybe its a combination of the white background and the recent distance between the individual recordlist areas, Example on page 0 (e.g. Category, File Storage, Dashboard, Redirects). https://imgur.com/a/OFW5T3S
  6. Annett Jähnichen commented on patch set 2 02/04/23, 17:22

    Reply

    Yes, I understand the concerns, also the fact that the group can be folded up is now somewhat lost.
  7. Annett Jähnichen uploaded patch set 3 V +1 02/04/23, 17:43

  8. core-ci voted on patch set 3 V +1 02/04/23, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37056

  9. Annett Jähnichen uploaded patch set 4 V +1 02/04/23, 17:58

  10. Annett Jähnichen commented on patch set 4 02/04/23, 18:00

    Reply

    Can you please take a look at Patchset 4. Maybe it is a good compromise.
  1. core-ci voted on patch set 4 V +1 02/04/23, 18:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37057

  2. Annett Jähnichen uploaded patch set 5 V +1 02/06/23, 16:51

  3. Annett Jähnichen updated the commit message in patch set 6 02/06/23, 16:51

  4. Annett Jähnichen marked it ready for review 02/06/23, 16:52

  5. Annett Jähnichen updated the commit message in patch set 7 02/06/23, 16:58

  6. core-ci voted on patch set 5 V -1 02/06/23, 17:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37185

  7. core-ci voted on patch set 6 V -1 02/06/23, 17:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37186

  8. Andreas Kienast uploaded patch set 8 02/06/23, 17:04

  9. Andreas Kienast voted on patch set 8 V +1 CR +1 02/06/23, 17:09

  10. Benni Mack commented on patch set 8 V +1 02/06/23, 17:10

    we still need this in the scheduler task listing, right?
  11. core-ci voted on patch set 7 V -1 02/06/23, 17:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37189

  12. Jasmina Ließmann commented on patch set 8 02/06/23, 17:15

    Reply

    Looks better to me, thanks! I wouldn't mind if the stripped table layout was retained.
  13. core-ci voted on patch set 8 V +1 02/06/23, 17:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37190

  14. Annett Jähnichen uploaded patch set 9 CR +1 V +1 02/06/23, 17:38

  15. Jasmina Ließmann voted on patch set 9 V +1 CR +1 02/06/23, 17:41

  16. Annett Jähnichen commented on patch set 9 02/06/23, 17:42

    Reply

    I have added the class back for now until we have a global solution for table view with stripes and their hover state.

    Reply

    The scheduler task listing uses panels and the look should now be the same.
  17. Christian Kuhn commented on patch set 8 02/06/23, 17:44

    TBH, I don't like the removal of the zebra-rows much: They give the eye some orientation and makes it much easier to align a title on the left with the buttons on the right. I don't want to vote-down either, and will abstain from voting.
  18. Christian Kuhn commented on patch set 9 02/06/23, 18:08

    Annett, my comment was too late, you pushed meanwhile. Many thanks, comment obsolete.
  19. Christian Kuhn commented on patch set 9 V +1 02/06/23, 18:10

    _module_web_list.scss:12

    wow. we still don't have variables for such colors?
  20. core-ci voted on patch set 9 V +1 02/06/23, 18:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37196

  21. Annett Jähnichen uploaded patch set 10 CR +1 V +1 02/06/23, 18:44

  22. core-ci voted on patch set 10 V +1 02/06/23, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37206

  23. Jasmina Ließmann voted on patch set 10 V +1 CR +1 02/06/23, 19:07

  24. Benni Mack voted on patch set 10 V +2 CR +2 02/06/23, 19:11

  25. Benni Mack merged patch set 11 02/06/23, 19:11