Review 11.5 Merged

77617[BUGFIX] Use correct language constraint in PageLayoutController

Oli Bartsch CR +2 V +2 Normal +33 −22 updated 01/26/23, 20:04

Commit message

When calculating the number of hidden elements for the
currently displayed language columns in the page module,
the corresponding language constraint is now properly set.

Considering more then one language is now only done,
in case language mode with a language > 0 is selected.

Additionally, L=-1 is now properly taken into account.

Some further cleanup of the method is done. The actually
defined field names of corresponding enable columns are
now used instead of the static ones.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Fabien Udriot +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 01/26/23, 19:41

  2. Oli Bartsch uploaded patch set 2 01/26/23, 19:44

  3. Fabien Udriot voted on patch set 2 CR +1 01/26/23, 19:55

  4. core-ci voted on patch set 2 V +1 01/26/23, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36663

  5. Oli Bartsch voted on patch set 2 V +2 CR +2 01/26/23, 20:04

  6. Oli Bartsch merged patch set 3 01/26/23, 20:04