Review main Merged

77623[FEATURE] Add country select form element to form framework

Chris Müller CR +2 V +2 Hard +377 −2 updated 03/14/23, 15:15

Commit message

With the introduction of the new country API and
the correspodning Fluid form viewhelper in #99618,
is the form framework extendend for a new form
element "country select".

The form element allows several configuration
options and renderes a single select element
in the frontend, using the corresponding form
viewhelper.

Following configuration options are available:

- First option: Defines the "empty option", i.e.
  the first element of the select.
- Prioritized countries: Defines a list of countries,
  which should be listed on top.
- Only countries: Defines the countries to be shown
  in the select list.
- Exclude countries: Defines the countries not to
  be shown in the list.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1830

Show 45 earlier messages
  1. Chris Müller uploaded patch set 1 01/27/23, 14:21

  2. core-ci voted on patch set 1 V +1 01/27/23, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36698

  3. Christoph Lehmann commented on patch set 1 01/28/23, 17:30

    >Should we set sortByOptionLabel always to true? Yes, please.
  4. Chris Müller uploaded patch set 2 V +1 02/03/23, 08:17

  5. Chris Müller commented on patch set 2 02/03/23, 08:17

    Reply

    Done
  1. core-ci voted on patch set 2 V +1 02/03/23, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36963

  2. Chris Müller updated the commit message in patch set 3 V +1 02/03/23, 08:48

  3. core-ci voted on patch set 3 V +1 02/03/23, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36965

  4. Chris Müller uploaded patch set 4 V +1 02/03/23, 09:26

  5. core-ci voted on patch set 4 V +1 02/03/23, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36969

  6. Chris Müller updated the commit message in patch set 5 V +1 02/06/23, 17:56

  7. core-ci voted on patch set 5 V +1 02/06/23, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37200

  8. Benni Mack rebased onto patch set 6 V +1 02/23/23, 21:44

  9. core-ci voted on patch set 6 V +1 02/23/23, 21:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38033

  10. Christian Eßl uploaded patch set 7 V +1 03/13/23, 09:30

  11. Christian Eßl updated the commit message in patch set 8 03/13/23, 09:33

  12. Christoph Lehmann wrote 03/13/23, 09:38

    Removed cc Christoph Lehmann.
  13. core-ci voted on patch set 7 V +1 03/13/23, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38863

  14. core-ci voted on patch set 8 V +1 03/13/23, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38864

  15. Christian Eßl uploaded patch set 9 V +1 03/13/23, 09:58

  16. core-ci voted on patch set 9 V +1 03/13/23, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38868

  17. Christian Eßl uploaded patch set 10 V +1 03/13/23, 10:15

  18. Christian Eßl updated the commit message in patch set 11 03/13/23, 10:15

  19. core-ci voted on patch set 10 V +1 03/13/23, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38870

  20. core-ci voted on patch set 11 V +1 03/13/23, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38871

  21. Oli Bartsch uploaded patch set 12 V +1 03/14/23, 12:49

  22. core-ci voted on patch set 12 V +1 03/14/23, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38921

  23. Oli Bartsch voted on patch set 12 V +1 CR +1 03/14/23, 13:30

  24. Benni Mack voted on patch set 12 V +2 CR +2 03/14/23, 15:15

  25. Benni Mack merged patch set 13 03/14/23, 15:15