Review main Merged

77629[BUGFIX] Fix input field with nullable checkbox

Torben Hansen CR +2 V +2 Easy +2 −2 updated 01/30/23, 09:31

Commit message

The change #99575 introduced a bug in formengine related
to input fields with a "null" checkbox placeholder.

This change fixes the bug by using the original CSS
class in `initializeNullWithPlaceholderCheckboxes()`

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Torben Hansen uploaded patch set 1 01/29/23, 11:24

  2. core-ci voted on patch set 1 V +1 01/29/23, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36730

  3. Oli Bartsch voted on patch set 1 V +2 CR +2 01/30/23, 09:20

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 01/30/23, 09:20

  5. Andreas Kienast commented on patch set 1 V +2 CR +2 01/30/23, 09:30

    Thanks, that's an obvious copy/paste mistake.
  6. Andreas Kienast merged patch set 2 01/30/23, 09:31