77634[TASK] Migrate legacy AdditionalConfiguration.php
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 2
Files 1
Review log 3853
Show 1828 earlier messages
-
Josef Glatz uploaded patch set 1 01/30/23, 07:03
-
Josef Glatz updated the commit message in patch set 2 01/30/23, 07:08
-
core-ci voted on patch set 1 V -1 01/30/23, 07:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36748
-
core-ci voted on patch set 2 V -1 01/30/23, 07:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36749
-
Josef Glatz uploaded patch set 3
V -101/30/23, 07:27 -
core-ci voted on patch set 3 V -1 01/30/23, 07:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36752
-
Josef Glatz uploaded patch set 4
V -101/30/23, 07:38 -
core-ci voted on patch set 4 V -1 01/30/23, 07:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36753
-
Simon Gilli commented on patch set 4 CR -1 01/30/23, 10:26
Thanks! I think this could be simplified...Bootstrap.php:224Instead of adding this condition again and again just call self::migrateLegacyAdditionalConfiguration($configurationManager) before and you should be doneBootstrap.php:229This check is done in the function already and can be removedBootstrap.php:244Don't think this needs to be declared publicBootstrap.php:255Don't think this needs to be declared public -
Josef Glatz commented on patch set 4 V -1 CR -1 01/30/23, 18:53
thanks for your input. I discussed another way with Georg and will push another patch -
Josef Glatz uploaded patch set 5
CR -1V -101/30/23, 21:24 -
Josef Glatz commented on patch set 5 01/30/23, 21:32
Hey folks, I have reduced the size of changes after talking to Georg. The patch now does extend the existing if-condition for the early return statement – just as little as possible. The existing logic is now only devided into 2 if-conditions without any functions in the Bootstrap class. I hope the local $renamed variable approach is acceptable in this lowlevel Bootstrap functions. I tried to keep the current implementation as much as possible. How to test: a typo3conf/AdditionalConfiguration.php is now also renamed if a settings.php is already in place. I'm looking forward to your feedback again and would then try to tackle the tests -
Josef Glatz commented on patch set 5 01/30/23, 21:33
Bootstrap.php:224ReplyDoneBootstrap.php:229ReplyDoneBootstrap.php:244ReplyDoneBootstrap.php:255ReplyDone -
Josef Glatz updated the commit message in patch set 6 01/30/23, 21:48
-
Josef Glatz commented on patch set 6 01/30/23, 21:48
This change is ready for review. -
core-ci voted on patch set 5 V -1 01/30/23, 22:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36798
-
core-ci voted on patch set 6 V -1 01/30/23, 22:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36800
-
Josef Glatz updated the commit message in patch set 7
V -101/31/23, 07:30 -
Benni Mack commented on patch set 7 01/31/23, 09:00
ConfigurationManager.php:144I don't think we need the new method. You can see that we already use getLegacyConfigPath() in Bootstrap. -
core-ci voted on patch set 7 V -1 01/31/23, 09:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36807
-
Josef Glatz uploaded patch set 8
V -102/14/23, 05:25 -
Josef Glatz commented on patch set 8 02/14/23, 05:26
ConfigurationManager.php:144ReplyDone -
core-ci voted on patch set 8 V -1 02/14/23, 06:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37670
-
Josef Glatz uploaded patch set 9
V -102/14/23, 11:28 -
Josef Glatz uploaded patch set 10 02/14/23, 11:33
-
core-ci voted on patch set 9 V +1 02/14/23, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37681
-
core-ci voted on patch set 10 V +1 02/14/23, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37682
-
Josef Glatz updated the commit message in patch set 11
V +102/14/23, 11:48
-
core-ci voted on patch set 11 V +1 02/14/23, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37685
-
Markus Klein commented on patch set 11 02/14/23, 12:36
Bootstrap.php:216extract this to variable as well please -
Josef Glatz commented on patch set 11 CR -1 02/14/23, 12:44
on it -
Josef Glatz uploaded patch set 12
CR -1V +102/14/23, 14:11 -
Josef Glatz commented on patch set 12 02/14/23, 14:12
Bootstrap.php:216ReplyDone -
core-ci voted on patch set 12 V +1 02/14/23, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37693
-
Josef Glatz commented on patch set 12 02/14/23, 14:19
- Moved all file_exists() calls into variables - Removed superfluous operators true/false - used local variables where it made sense - removed detailed scenario notes (moved to issue description) and added just relevant migration scenarios to the commit message -
Markus Klein uploaded patch set 13
V +102/14/23, 14:46 -
Markus Klein commented on patch set 13 CR +1 02/14/23, 14:47
Only moved some variables around. Nice stuff -
core-ci voted on patch set 13 V +1 02/14/23, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37694
-
Georg Ringer voted on patch set 13 V +1 CR +1 02/15/23, 07:43
-
Oli Bartsch commented on patch set 13 02/16/23, 09:57
Bootstrap.php:238Just to be consistent, should we also add a $legacyLocalConfigurationFileExists variable? -
Markus Klein commented on patch set 13 CR -1 02/16/23, 10:36
Bootstrap.php:238Replythought about this, but 1) it's only needed once here 2) it's only done when really needed. But thinking about it again, I'll optimize the code for performance (less disk I/O) again -
Markus Klein uploaded patch set 14
CR +1V +102/16/23, 10:43 -
Markus Klein commented on patch set 14 02/16/23, 10:44
Bootstrap.php:238ReplyDone -
core-ci voted on patch set 14 V +1 02/16/23, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37792
-
Markus Klein voted on patch set 14 V +1 CR +1 02/16/23, 11:36
-
Oli Bartsch commented on patch set 14 V -1 02/20/23, 11:10
Bootstrap.php:250This might lead to the fact that the method returns true even no system.php file exists. -
Oli Bartsch uploaded patch set 15
CR +1V +102/20/23, 11:36 -
Oli Bartsch commented on patch set 15 V +1 CR +1 02/20/23, 11:43
Bootstrap.php:250ReplyDone -
core-ci voted on patch set 15 V +1 02/20/23, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37891
-
Benni Mack voted on patch set 15 V +2 CR +2 02/22/23, 11:56
-
Benni Mack merged patch set 16 02/22/23, 11:56
-
Markus Klein commented on patch set 16 02/22/23, 12:21
Post -1Bootstrap.php:232I explicitly designed my version (Patch 14) so that we have minimal I/O for this code executed for every request. We no check for a legacy addtionalconfig file for every request! -
Markus Klein commented on patch set 16 02/22/23, 12:40
Bootstrap.php:232ReplyFollowup in https://forge.typo3.org/issues/100013