Review main Merged

77640[TASK] Simplify IncludeTree identifier calculation

Christian Kuhn CR +2 V +2 Normal +118 −121 updated 01/30/23, 16:39

Commit message

We need unique identifiers in both TypoScript
"AST" and "IncludeTree" to reference nodes in
the backend modules.

This has been established with #99537 for the
include tree already, while #99747 came with
a simplified approach for AST nodes.

The patch changes the include tree approach to
use the same simplified version as done with
AST nodes, which avoids some runtime overhead
in non-backend context.

As drive-by, the HTML of "Active PageTsConfig"
view is streamlined a bit.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 3

Files 21

Show 1 more file

Review log 1115

  1. Christian Kuhn uploaded patch set 1 01/30/23, 15:16

  2. core-ci voted on patch set 1 V -1 01/30/23, 15:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36775

  3. Christian Kuhn uploaded patch set 2 V -1 01/30/23, 15:29

  4. Christian Kuhn voted on patch set 2 CR -1 01/30/23, 15:30

  5. core-ci voted on patch set 2 V -1 01/30/23, 15:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36776

  6. core-ci voted on patch set 2 V +1 01/30/23, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36776

  7. Christian Kuhn uploaded patch set 3 CR -1 V +1 01/30/23, 16:08

  8. Christian Kuhn updated the commit message in patch set 4 01/30/23, 16:10

  9. core-ci voted on patch set 4 V +1 01/30/23, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36780

  10. Stefan Bürk voted on patch set 4 V +1 CR +1 01/30/23, 16:31

  11. Nikita Hovratov commented on patch set 4 01/30/23, 16:33

    AbstractNode.php:73

    extra whitespace
  12. Christian Kuhn commented on patch set 4 01/30/23, 16:34

    AbstractNode.php:73 Reply

    i think there's no hard rule for this. i personally find the whitespace better readable.
  13. Nikita Hovratov voted on patch set 4 V +1 CR +1 01/30/23, 16:36

  14. Christian Kuhn voted on patch set 4 V +2 CR +2 01/30/23, 16:38

  15. Christian Kuhn merged patch set 5 01/30/23, 16:39