77640[TASK] Simplify IncludeTree identifier calculation
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 3
Files 21
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigActiveController.php+0 −3
- typo3/sysext/backend/Resources/Private/Templates/PageTsConfig/Active.html+8 −8
- typo3/sysext/core/Classes/TypoScript/AST/Node/AbstractNode.php2+6 −4
- typo3/sysext/core/Classes/TypoScript/AST/Node/NodeInterface.php+1 −1
- typo3/sysext/core/Classes/TypoScript/AST/Node/RootNode.php+0 −8
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/AbstractInclude.php+6 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/IncludeInterface.php+8 −5
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeConditionIncludeListAccumulatorVisitor.php+0 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/StringTreeBuilder.php+0 −2
- typo3/sysext/core/Classes/TypoScript/IncludeTree/SysTemplateTreeBuilder.php+0 −11
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TreeFromLineStreamBuilder.php+0 −35
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TsConfigTreeBuilder.php+0 −3
- typo3/sysext/core/Classes/TypoScript/PageTsConfigFactory.php+0 −3
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/IncludeTreeObjectIgnoringIdentifierAndPathComparator.php+2 −2
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/TreeFromLineStreamBuilderTest.php+2 −17
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/UnserializedIncludeTreeObjectComparator.php+1 −1
- typo3/sysext/core/Tests/Unit/TypoScript/AST/Node/ChildNodeTest.php+6 −6
- typo3/sysext/core/Tests/Unit/TypoScript/AST/Node/ReferenceChildNodeTest.php+6 −6
- typo3/sysext/core/Tests/Unit/TypoScript/AST/Node/RootNodeTest.php+4 −4
- typo3/sysext/core/Tests/Unit/TypoScript/IncludeTree/IncludeNode/RootNodeTest.phpnew+66 −0
Review log 1115
-
Christian Kuhn uploaded patch set 1 01/30/23, 15:16
-
core-ci voted on patch set 1 V -1 01/30/23, 15:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36775
-
Christian Kuhn uploaded patch set 2
V -101/30/23, 15:29 -
Christian Kuhn voted on patch set 2 CR -1 01/30/23, 15:30
-
core-ci voted on patch set 2 V -1 01/30/23, 15:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36776
-
core-ci voted on patch set 2 V +1 01/30/23, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36776
-
Christian Kuhn uploaded patch set 3
CR -1V +101/30/23, 16:08 -
Christian Kuhn updated the commit message in patch set 4 01/30/23, 16:10
-
core-ci voted on patch set 4 V +1 01/30/23, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36780
-
Stefan Bürk voted on patch set 4 V +1 CR +1 01/30/23, 16:31
-
Nikita Hovratov commented on patch set 4 01/30/23, 16:33
-
Christian Kuhn commented on patch set 4 01/30/23, 16:34
AbstractNode.php:73Replyi think there's no hard rule for this. i personally find the whitespace better readable. -
Nikita Hovratov voted on patch set 4 V +1 CR +1 01/30/23, 16:36
-
Christian Kuhn voted on patch set 4 V +2 CR +2 01/30/23, 16:38
-
Christian Kuhn merged patch set 5 01/30/23, 16:39
AbstractNode.php:73