77643[BUGFIX] Apply TCA migrations for FlexForm in DataHandler
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Oli Bartsch +1
- Stefan Bürk +1
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Oli Bartsch +1
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFlexPrepare.php+1 −69
- typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php+55 −13
- typo3/sysext/core/Tests/Functional/Configuration/FlexForm/FlexFormToolsTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield/Configuration/FlexForms/tt_content_flexform.xml+1 −10
Review log 1520
-
Nikita Hovratov uploaded patch set 1 01/30/23, 17:03
-
core-ci voted on patch set 1 V -1 01/30/23, 17:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36783
-
Nikita Hovratov uploaded patch set 2
V -101/30/23, 19:59 -
core-ci voted on patch set 2 V +1 01/30/23, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36795
-
Nikita Hovratov uploaded patch set 3
V +101/30/23, 20:56 -
core-ci voted on patch set 3 V +1 01/30/23, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36796
-
Nikita Hovratov updated the commit message in patch set 4
V +101/30/23, 21:12 -
core-ci voted on patch set 4 V +1 01/30/23, 21:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36797
-
Nikita Hovratov uploaded patch set 5
V +101/30/23, 21:32 -
core-ci voted on patch set 5 V +1 01/30/23, 21:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36799
-
Benni Mack commented on patch set 5 01/31/23, 08:49
I think I had similar issues in v11, how about we also backport this to v11? I think this was related to some other migrations in TCA (type=language or so). -
Benni Mack commented on patch set 5 CR +1 01/31/23, 09:54
ah, saw the cherry-pick already -
Nikita Hovratov commented on patch set 5 01/31/23, 10:02
Reply
Seems not so easy to cherry-pick, as now the sequence of removing the TCEForms and TcaMigration is reversed, causing tests to fail. This is already taken care of in v12 as a breaking change: ttps://review.typo3.org/c/Packages/TYPO3.CMS/+/73835 So, v12 only then? -
Benni Mack commented on patch set 5 01/31/23, 13:25
yes. fine. -
Christian Kuhn commented on patch set 5 V +1 CR +1 02/01/23, 19:28
this should be fine i suppose. maybe oli can have another eye? -
Oli Bartsch commented on patch set 5 CR -1 02/01/23, 19:50
Reply
Thanks for the reminder. Will review tomorrow. -
Oli Bartsch commented on patch set 5 V +1 CR +1 02/02/23, 18:13
Looks good. Thanks! -
Stefan Bürk commented on patch set 5 V +1 CR +1 02/02/23, 21:13
Reply
Done -
Nikita Hovratov voted on patch set 5 V +2 CR +2 02/03/23, 08:59
-
Nikita Hovratov merged patch set 6 02/03/23, 09:00