Review main Merged

77648[BUGFIX] Build extbase attribute in UriBuilder fallback

Christian Kuhn CR +2 V +2 Easy +18 −5 updated 01/31/23, 13:14

Commit message

With getRequest() in UriBuilder returning a
extbase Request in the fallback chain, we need
to have an extbase attribute when creating it.

Also avoid another call to $GLOBALS['TYPO3_REQUEST'].

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Benni Mack +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 4

Files 2

Review log 57

  1. Christian Kuhn uploaded patch set 1 01/31/23, 12:07

  2. Torben Hansen uploaded patch set 2 01/31/23, 12:11

  3. core-ci voted on patch set 2 V +1 01/31/23, 12:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36816

  4. Torben Hansen voted on patch set 2 V +1 CR +1 01/31/23, 12:23

  5. core-ci voted on patch set 1 V +1 01/31/23, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36815

  6. Benni Mack voted on patch set 2 V +2 CR +2 01/31/23, 13:14

  7. Benni Mack merged patch set 3 01/31/23, 13:14