Review main Merged

77651[TASK] Cleanup of type for sameBeginEnd in ContentObjectRenderer

Thomas Hohn CR +2 V +2 Easy +2 −2 updated 02/01/23, 08:25

Commit message

The variable sameBeginEnd should have the type bool, since the
comparison calculation yields a bool.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Thomas Hohn uploaded patch set 1 01/31/23, 18:15

  2. Thomas Hohn updated the commit message in patch set 2 01/31/23, 18:16

  3. core-ci voted on patch set 1 V +1 01/31/23, 18:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36837

  4. core-ci voted on patch set 2 V +1 01/31/23, 18:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36838

  5. Benni Mack voted on patch set 2 CR +1 01/31/23, 20:00

  6. Oliver Klee voted on patch set 2 CR +1 01/31/23, 20:17

  7. Simon Schaufelberger voted on patch set 2 V +1 CR +1 02/01/23, 03:27

  8. Oli Bartsch voted on patch set 2 V +2 CR +2 02/01/23, 08:25

  9. Oli Bartsch merged patch set 3 02/01/23, 08:25