77658[BUGFIX] Avoid re-paints and re-layouts in page tree on drag&drop
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Markus Klein +1
- Stefan Bürk +1
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 6
- Build/Sources/TypeScript/backend/page-tree/page-tree-element.ts+3 −2
- Build/Sources/TypeScript/backend/tree/drag-drop.ts3+11 −22
- Build/Sources/TypeScript/backend/tree/file-storage-tree-container.ts+0 −4
- typo3/sysext/backend/Resources/Public/JavaScript/page-tree/page-tree-element.js2+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/tree/drag-drop.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/tree/file-storage-tree-container.js+1 −1
Review log 2431
Show 46 earlier messages
-
Andreas Kienast uploaded patch set 1 02/01/23, 14:20
-
core-ci voted on patch set 1 V +1 02/01/23, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36877
-
Andreas Kienast uploaded patch set 2
V +102/01/23, 14:33 -
Andreas Kienast uploaded patch set 3 02/01/23, 14:36
-
Andreas Kienast uploaded patch set 4 02/01/23, 14:42
-
core-ci voted on patch set 3 V +1 02/01/23, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36879
-
core-ci voted on patch set 2 V +1 02/01/23, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36878
-
core-ci voted on patch set 4 V +1 02/01/23, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36880
-
Christian Kuhn voted on patch set 4 V +1 CR +1 02/01/23, 15:15
-
Markus Klein voted on patch set 4 CR +1 02/01/23, 15:31
-
Andreas Kienast uploaded patch set 5
CR +1V +102/01/23, 15:48 -
Markus Klein voted on patch set 5 CR +1 02/01/23, 15:50
-
Markus Klein commented on patch set 5 CR 0 02/01/23, 15:52
-
Markus Klein commented on patch set 5 02/01/23, 15:53
page-tree-element.js:81overlooked conflict on rebase -
Andreas Kienast commented on patch set 5 02/01/23, 15:54
drag-drop.ts:74ReplyNope. With the latest patch, this property was added. However, with this bugfix applied, dropping any node is not possible anymore otherwise. The issue is that page-tree-element.ts calls `this.dragDrop.isDropAllowed()` to check if dropping a node is allowed right before having the chance to determine whether it's really allowed or not. -
Christian Kuhn uploaded patch set 6 02/01/23, 15:55
-
Christian Kuhn commented on patch set 5 02/01/23, 15:56
page-tree-element.js:81ReplyDone -
Benni Mack commented on patch set 6 V +1 CR +1 02/01/23, 15:59
totally fine, I introduced this bug this morning. Thanks for the quick fix -
Andreas Kienast commented on patch set 6 V -1 02/01/23, 16:00
something is broken rn -
Christian Kuhn commented on patch set 6 V -1 02/01/23, 16:00
can not drop anywhere with set 6. -
core-ci voted on patch set 5 V -1 02/01/23, 16:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36886
-
core-ci voted on patch set 6 V +1 02/01/23, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36887
-
Andreas Kienast uploaded patch set 7
CR +1V +102/01/23, 16:10 -
core-ci voted on patch set 7 V +1 02/01/23, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36888
-
Benni Mack voted on patch set 7 V +1 CR +1 02/01/23, 16:23
-
Christian Kuhn commented on patch set 7 02/01/23, 19:14
drag-drop.ts:74ReplyDone -
Christian Kuhn voted on patch set 7 V +1 CR +1 02/01/23, 19:16
-
Markus Klein voted on patch set 7 CR +1 02/01/23, 20:41
-
Stefan Bürk voted on patch set 7 V +1 CR +1 02/02/23, 04:27
-
Andreas Kienast voted on patch set 7 V +2 CR +2 02/02/23, 07:54
-
Andreas Kienast merged patch set 8 02/02/23, 07:54
drag-drop.ts:74