Review main Merged

77663[BUGFIX] Fix order of form-check elements

Oli Bartsch CR +2 V +2 Normal +60 −60 updated 02/02/23, 00:33

Commit message

In a "form-check" container, the input element with class
"form-check-input" must be placed before the
corresponding label with class "form-check-label".

This fixes a related display bug in Firefox.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 56

  1. Oli Bartsch uploaded patch set 1 02/01/23, 20:16

  2. core-ci voted on patch set 1 V +1 02/01/23, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36899

  3. Jasmina Ließmann voted on patch set 1 V +1 CR +1 02/01/23, 20:27

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 02/02/23, 00:31

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 02/02/23, 00:33

  6. Christian Kuhn merged patch set 2 02/02/23, 00:33