Review main Merged

77664[TASK] Prefer browser tooltips over bootstrap tooltips

Christian Kuhn CR +2 V +2 Hard +115 −191 updated 02/04/23, 15:23

Commit message

The entire bootstrap tooltips plugin and Backend
handling is problemetic. The patch removes usages
throughout the Backend to rely solely on native
browser title attributes on hover for now.

Reasons:
* Usage within the Backend is very inconsistent: Some
  modules use 'bs-toggle="tooltip"', some do, but then
  don't initialze JS accordingly, many don't take care
  at all.
* The placement of tooltips is inconsistent: Some modules
  rely on auto placement, some don't take care, some
  get it right.
* The plugin is fiddly: There are various hacks to for
  instance toggle-off on scroll, or toggle-off when a
  modal is overlayed to not stay on-top-of modals, these
  sort of things. Browser title hovers always get this right.
* Usages are buggy: The page tree sometimes still fails
  to remove tooltips, which then tend to stay until browser
  reload. The list module shows both a browser hover plus
  the tooltip at the same time on icons, ext:form shows funny
  placement in preview-mode. There are more modules that get
  details wrong than those that work flawlessly.
* Tooltips that add a lot of valuable information are
  problematic from an accessibility point of view. It's
  better to refactor UI to not rely on them too much. By
  avoiding bootstrap tooltips for now, we encourage to
  think more about properly accessible solutions instead
  of putting things into a "nice" overlay. With the patch,
  various places now fall back to the title attribute, which
  is also problematic, see [1] for more information. The
  core will continue to improve the situation with
  further patches and will document better best practices.
* Tooltips with a lot of additional information are a
  no-go on touch devices.
* The plugin is slow with many elements. This is easily
  reproducible with the "List" module, which is noticeable
  quicker when relying on title tags alone on weaker clients.

[1] https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/title#accessibility_concerns

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Stefan Bürk +1
    • Michael Telgkamp +1
    • core-ci +1 CI

Issues 7

Files 53

Show 33 more files

Review log 1827

Show 2 earlier messages
  1. Christian Kuhn uploaded patch set 1 02/01/23, 23:44

  2. Christian Kuhn updated the commit message in patch set 2 02/02/23, 00:04

  1. core-ci voted on patch set 1 V -1 02/02/23, 00:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36902

  2. core-ci voted on patch set 2 V -1 02/02/23, 01:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36903

  3. Christian Kuhn uploaded patch set 3 V -1 02/02/23, 01:22

  4. core-ci voted on patch set 3 V -1 02/02/23, 02:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36906

  5. Christian Kuhn uploaded patch set 4 V -1 02/03/23, 16:37

  6. core-ci voted on patch set 4 V -1 02/03/23, 16:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37000

  7. Christian Kuhn uploaded patch set 5 V -1 02/03/23, 17:47

  8. core-ci voted on patch set 5 V +1 02/03/23, 17:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37006

  9. Christian Kuhn updated the commit message in patch set 6 V +1 02/03/23, 17:56

  10. core-ci voted on patch set 6 V +1 02/03/23, 18:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37007

  11. Christian Kuhn uploaded patch set 7 V +1 02/03/23, 18:11

  12. core-ci voted on patch set 7 V -1 02/03/23, 18:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37008

  13. Christian Kuhn uploaded patch set 8 V -1 02/03/23, 18:18

  14. core-ci voted on patch set 8 V +1 02/03/23, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37009

  15. Stefan Bürk voted on patch set 8 CR +1 02/03/23, 19:00

  16. Stefan Bürk commented on patch set 8 V +1 02/03/23, 19:12

    7/7 ack ...
  17. Michael Telgkamp commented on patch set 8 V -1 CR -1 02/03/23, 20:00

    The title attribute is not accessible for all users. More information can be found e.g. at the MDN page https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/title#accessibility_concerns and the links in that section. The title attribute should only be used in cases where it is intended to be used, like iframes or input elements with pattern that need to be matched.
  18. Christian Kuhn uploaded patch set 9 CR +1 V +1 02/03/23, 20:24

  19. Christian Kuhn commented on patch set 9 02/03/23, 20:24

    Reply

    Done
  20. core-ci voted on patch set 9 V +1 02/03/23, 20:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37012

  21. Michael Telgkamp commented on patch set 9 V +1 02/03/23, 20:39

    Thank you for clarification in the commit message.
  22. Stefan Bürk voted on patch set 9 V +1 CR +1 02/03/23, 20:40

  23. Jasmina Ließmann voted on patch set 9 V +1 CR +1 02/04/23, 15:13

  24. Christian Kuhn voted on patch set 9 V +2 CR +2 02/04/23, 15:23

  25. Christian Kuhn merged patch set 10 02/04/23, 15:23