Review 11.5 Merged

77669[BUGFIX] Avoid re-paints and re-layouts in page tree on drag&drop

Andreas Kienast CR +2 V +2 Easy +16 −17 updated 02/02/23, 07:55

Commit message

When using drag&drop in the page tree, many style changes happen:

* a shadow node is rendered that is moved around
* the content within the shadow node changes depending on whether
  dropping is allowed
* CSS classes are changed

The previous implementation was not optimal in several ways:

* the nodes wrapper (aka the "tree") was updated twice which each
  `dragover` event, being expensive on huge trees
* adding and removing CSS classes may have become redundant in some
  cases, triggering a re-paint every time

All these cases are handled in this patch by executing tasks only when
absolutely necessary.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Andreas Kienast uploaded patch set 1 02/02/23, 07:42

  2. core-ci voted on patch set 1 V +1 02/02/23, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36917

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 02/02/23, 07:55

  4. Andreas Kienast merged patch set 2 02/02/23, 07:55