Review main Merged

77672[FEATURE] Introduce ModifyRedirectManagementControllerViewDataEvent

Stefan Bürk CR +2 V +2 Hard +391 −24 updated 03/21/23, 01:41

Commit message

A new PSR-14 event "ModifyRedirectManagementControllerViewDataEvent"
is introduced, allowing extension authors to modify or enrich view
data for the ManagementController. Especially view is exchanged to
display more or other information along the way.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Guido Schmechel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Guido Schmechel +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 3952

Show 1927 earlier messages
  1. Stefan Bürk uploaded patch set 1 02/02/23, 20:08

  2. core-ci voted on patch set 1 V +1 02/02/23, 20:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36932

  3. Stefan Bürk uploaded patch set 2 V +1 02/02/23, 21:01

  4. core-ci voted on patch set 2 V +1 02/02/23, 21:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36939

  5. Stefan Froemken commented on patch set 2 02/03/23, 10:40

    Just "information".

    ManagementController.php:48

    I would prefer "private readonly"

    ModifyRedirectManagementControllerViewDataEvent.php:89

    Do we really need all these annotations in times of strict types and strict typed properties? I would remove all of them.

    ManagementControllerTest.php:63

    Ahh Ok...you need that annotation because of the "set" method which is not part of the ContainerInterface.
  6. Stefan Bürk uploaded patch set 3 V +1 02/03/23, 10:47

  7. Stefan Bürk commented on patch set 2 02/03/23, 10:47

    Reply

    Done

    ManagementController.php:48 Reply

    Done

    ModifyRedirectManagementControllerViewDataEvent.php:89 Reply

    Done
  8. Stefan Froemken voted on patch set 3 CR +1 02/03/23, 10:57

  9. core-ci voted on patch set 3 V +1 02/03/23, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36972

  10. Benni Mack voted on patch set 3 CR +1 02/03/23, 23:33

  11. Stefan Bürk commented on patch set 4 CR +1 V +1 02/05/23, 19:56

    Published edit on patch set 3.
  12. core-ci voted on patch set 4 V +1 02/05/23, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37128

  13. Chris Müller uploaded patch set 5 V +1 02/08/23, 17:50

  14. core-ci voted on patch set 5 V +1 02/08/23, 18:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37400

  15. Stefan Froemken voted on patch set 5 CR +1 02/09/23, 10:14

  16. Stefan Bürk voted on patch set 5 CR -1 02/09/23, 20:24

  17. Stefan Bürk rebased onto patch set 6 CR +1 V +1 02/23/23, 09:56

  18. core-ci voted on patch set 6 V +1 02/23/23, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37997

  19. Sybille Peters uploaded patch set 7 V +1 02/25/23, 15:05

  20. Sybille Peters commented on patch set 6 CR +1 02/25/23, 15:06

    Feature-99802-NewPSR-14ModifyRedirectManagementControllerViewDataEvent.rst:19

    > features following methods => the following methods

    Feature-99802-NewPSR-14ModifyRedirectManagementControllerViewDataEvent.rst:36

    > and directly assigning them , directly assigning them

    Feature-99802-NewPSR-14ModifyRedirectManagementControllerViewDataEvent.rst:38

    > and the decided place a bit unclear (to me)

    Feature-99802-NewPSR-14ModifyRedirectManagementControllerViewDataEvent.rst:38

    > and with overriding the view template over PageTS that can be displayed while overriding the view template via Page TSconfig

    Feature-99802-NewPSR-14ModifyRedirectManagementControllerViewDataEvent.rst:46

    Can add the file name via :caption: (is common practice in docs now) :caption: EXT:my_extension/Configuration/Services.yaml
  21. Sybille Peters voted on patch set 7 CR +1 02/25/23, 15:06

  22. core-ci voted on patch set 7 V +1 02/25/23, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38100

  23. Sybille Peters commented on patch set 7 02/25/23, 17:00

    Feature-99802-NewPSR-14ModifyRedirectManagementControllerViewDataEvent.rst:46 Reply

    Done
  24. Stefan Bürk uploaded patch set 8 CR +1 V +1 02/26/23, 15:16

  25. Stefan Bürk commented on patch set 7 02/26/23, 15:16

    Feature-99802-NewPSR-14ModifyRedirectManagementControllerViewDataEvent.rst:38 Reply

    Changed. Hope it's clearer now.
  26. Sybille Peters voted on patch set 8 CR +1 02/26/23, 15:18

  27. core-ci voted on patch set 8 V +1 02/26/23, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38119

  1. Sybille Peters commented on patch set 8 02/26/23, 20:15

    Feature-99802-NewPSR-14ModifyRedirectManagementControllerViewDataEvent.rst:38 Reply

    Done
  2. Georg Ringer voted on patch set 8 V +1 CR +1 03/03/23, 11:56

  3. Georg Ringer uploaded patch set 9 CR +1 V +1 03/03/23, 12:01

  4. core-ci voted on patch set 9 V +1 03/03/23, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38355

  5. Benni Mack voted on patch set 9 CR +1 03/07/23, 14:33

  6. Jörg Bösche voted on patch set 9 CR +1 03/10/23, 07:31

  7. Benni Mack voted on patch set 9 V +1 03/16/23, 22:10

  8. Stefan Bürk uploaded patch set 10 CR +1 V +1 03/17/23, 05:54

  9. core-ci voted on patch set 10 V +1 03/17/23, 06:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39095

  10. Georg Ringer voted on patch set 10 V +1 CR +1 03/17/23, 07:21

  11. Stefan Froemken commented on patch set 10 CR -1 03/17/23, 10:59

    Feature-99802-NewPSR-14ModifyRedirectManagementControllerViewDataEvent.rst:77

    I prefer "static fn" here

    Feature-99802-NewPSR-14ModifyRedirectManagementControllerViewDataEvent.rst:77

    Missing =>
  12. Stefan Froemken uploaded patch set 11 CR +1 V +1 03/17/23, 11:10

  13. Stefan Froemken commented on patch set 11 03/17/23, 11:12

    Feature-99802-NewPSR-14ModifyRedirectManagementControllerViewDataEvent.rst:77

    Has to be $host['name']
  14. Stefan Froemken uploaded patch set 12 03/17/23, 11:12

  15. Stefan Froemken commented on patch set 12 V +1 CR +1 03/17/23, 11:13

    Feature-99802-NewPSR-14ModifyRedirectManagementControllerViewDataEvent.rst:77 Reply

    Done

    Feature-99802-NewPSR-14ModifyRedirectManagementControllerViewDataEvent.rst:77 Reply

    Done

    Feature-99802-NewPSR-14ModifyRedirectManagementControllerViewDataEvent.rst:77 Reply

    Done
  16. core-ci voted on patch set 11 V +1 03/17/23, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39115

  17. Stefan Bürk commented on patch set 12 03/17/23, 11:22

    Feature-99802-NewPSR-14ModifyRedirectManagementControllerViewDataEvent.rst:77 Reply

    ack.
  18. core-ci voted on patch set 12 V +1 03/17/23, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39116

  19. Stefan Bürk uploaded patch set 13 CR +1 V +1 03/18/23, 17:00

  20. core-ci voted on patch set 13 V +1 03/18/23, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39188

  21. Guido Schmechel commented on patch set 13 V +1 CR +1 03/20/23, 21:40

    My test was to edit a demand so that the editor gets filtered 301 codes delivered directly. I was able to receive the demand, but I could not change this demand because all the setters were missing. Is this maybe still part of the patch? It would lend itself to. Alternatively, perhaps as a FollowUp Patch with TASK classification. The event works as it should, hence the +1 vote for the time being.
  22. Benni Mack voted on patch set 13 V +1 CR +1 03/20/23, 23:00

  23. Stefan Bürk commented on patch set 13 03/21/23, 01:39

    Reply

    The demand object does not need setters itself. You can create a new one and set it to the event. ``` $event->setDemand( new Demand( $demand->getPage(), $demand->getOrderField(), ... $customStatusCodes, // instead from orginal demand ), ); ``` But it's on the todo list to overwork the demand class itself (extracting the factory methods etc) as a dedicated patch (task), which is possible as the demand object is internal. I decided to add the demand object for now, as it eleminates at least to xclass the controller for now.
  24. Stefan Bürk voted on patch set 13 V +2 CR +2 03/21/23, 01:41

  25. Stefan Bürk merged patch set 14 03/21/23, 01:41