77673[TASK] Streamline "versionNumberedFilename"
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Josef Glatz +1
- Oli Bartsch +1
-
Verified V +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/core/Classes/Utility/GeneralUtility.php2+15 −19
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −1
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml2+6 −9
- typo3/sysext/core/Documentation/Changelog/12.3/Deprecation-99810-VersionNumberedFilenameOptionNowBoolean.rstnew+59 −0
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php2+20 −0
- typo3/sysext/install/Tests/Unit/Service/SilentConfigurationUpgradeServiceTest.php+18 −0
Review log 1727
Show 12 earlier messages
-
Benni Mack uploaded patch set 1 02/02/23, 20:55
-
core-ci voted on patch set 1 V +1 02/02/23, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36937
-
Benni Mack updated the commit message in patch set 2
V +102/03/23, 17:09 -
core-ci voted on patch set 2 V +1 02/03/23, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37004
-
Benni Mack uploaded patch set 3
V +102/06/23, 17:32 -
Oli Bartsch commented on patch set 3 02/06/23, 17:52
DefaultConfigurationDescription.yaml:529The description seems to be wrong as it describes the backend variant of this option.Deprecation-99810-CreateVersionNumberedFilenameOptionNowBoolean.rst:16empty line to before the first bullet is required for proper rendering.Deprecation-99810-CreateVersionNumberedFilenameOptionNowBoolean.rst:56This sentence is hard to read. at least "to" and "due" need to be swappedSilentConfigurationUpgradeService.php:1127Are we sure a configuration change took place at this point? -
core-ci voted on patch set 3 V +1 02/06/23, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37192
-
Benni Mack commented on patch set 4
V +102/08/23, 07:50Published edit on patch set 3. -
core-ci voted on patch set 4 V +1 02/08/23, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37330
-
Benni Mack uploaded patch set 5
V +102/08/23, 08:26 -
core-ci voted on patch set 5 V +1 02/08/23, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37336
-
Benni Mack voted on patch set 5 CR -1 02/08/23, 09:33
-
Benni Mack uploaded patch set 6
CR -1V +102/10/23, 21:25 -
Benni Mack uploaded patch set 7 02/10/23, 21:26
-
Benni Mack uploaded patch set 8 02/10/23, 21:26
-
Benni Mack commented on patch set 6 02/10/23, 21:26
GeneralUtility.php:2110ReplyDoneDefaultConfigurationDescription.yaml:529ReplyDoneDeprecation-99810-CreateVersionNumberedFilenameOptionNowBoolean.rst:16ReplyDoneDeprecation-99810-CreateVersionNumberedFilenameOptionNowBoolean.rst:56ReplyDoneSilentConfigurationUpgradeService.php:1127Replyadded a test for this -
core-ci voted on patch set 7 V -1 02/10/23, 21:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37588
-
core-ci voted on patch set 6 V -1 02/10/23, 21:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37587
-
core-ci voted on patch set 8 V -1 02/10/23, 22:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37589
-
Benni Mack uploaded patch set 9
V -102/11/23, 09:43 -
core-ci voted on patch set 9 V +1 02/11/23, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37604
-
Oli Bartsch uploaded patch set 10
V +102/11/23, 12:20 -
Oli Bartsch voted on patch set 10 V +1 CR +1 02/11/23, 12:20
-
core-ci voted on patch set 10 V +1 02/11/23, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37606
-
Josef Glatz voted on patch set 10 CR +1 02/12/23, 21:59
-
Georg Ringer voted on patch set 10 V +2 CR +2 02/13/23, 06:18
-
Georg Ringer merged patch set 11 02/13/23, 06:18
GeneralUtility.php:2110