Review main Merged

77673[TASK] Streamline "versionNumberedFilename"

Benni Mack CR +2 V +2 Normal +119 −29 updated 02/13/23, 06:18

Commit message

TYPO3 has two global configuration settings:

$TYPO3_CONF_VARS['BE']['versionNumberInFilename']
which acts as a boolean.

$TYPO3_CONF_VARS['FE']['versionNumberInFilename']
which has three options: '', 'embed' and 'querystring'.

This change streamlines both flags to only allow
boolean:
false => append the filemtime to the asset file
true => change the filename to "myfile.[timestamp].extension"

This means, that FE now has the previous
default option 'querystring' migrated to false,
where as 'embed' is automatically migrated to true.

This is done in an automated migration
via the SilentConfigurationUpgrade service.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1727

Show 12 earlier messages
  1. Benni Mack uploaded patch set 1 02/02/23, 20:55

  2. core-ci voted on patch set 1 V +1 02/02/23, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36937

  1. Benni Mack updated the commit message in patch set 2 V +1 02/03/23, 17:09

  2. core-ci voted on patch set 2 V +1 02/03/23, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37004

  3. Benni Mack uploaded patch set 3 V +1 02/06/23, 17:32

  4. Oli Bartsch commented on patch set 3 02/06/23, 17:52

    GeneralUtility.php:2110

    This is now the same as for the backend, the bool TRUE, right?

    DefaultConfigurationDescription.yaml:529

    The description seems to be wrong as it describes the backend variant of this option.

    Deprecation-99810-CreateVersionNumberedFilenameOptionNowBoolean.rst:16

    empty line to before the first bullet is required for proper rendering.

    Deprecation-99810-CreateVersionNumberedFilenameOptionNowBoolean.rst:56

    This sentence is hard to read. at least "to" and "due" need to be swapped

    SilentConfigurationUpgradeService.php:1127

    Are we sure a configuration change took place at this point?
  5. core-ci voted on patch set 3 V +1 02/06/23, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37192

  6. Benni Mack commented on patch set 4 V +1 02/08/23, 07:50

    Published edit on patch set 3.
  7. core-ci voted on patch set 4 V +1 02/08/23, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37330

  8. Benni Mack uploaded patch set 5 V +1 02/08/23, 08:26

  9. core-ci voted on patch set 5 V +1 02/08/23, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37336

  10. Benni Mack voted on patch set 5 CR -1 02/08/23, 09:33

  11. Benni Mack uploaded patch set 6 CR -1 V +1 02/10/23, 21:25

  12. Benni Mack uploaded patch set 7 02/10/23, 21:26

  13. Benni Mack uploaded patch set 8 02/10/23, 21:26

  14. Benni Mack commented on patch set 6 02/10/23, 21:26

    GeneralUtility.php:2110 Reply

    Done

    DefaultConfigurationDescription.yaml:529 Reply

    Done

    Deprecation-99810-CreateVersionNumberedFilenameOptionNowBoolean.rst:16 Reply

    Done

    Deprecation-99810-CreateVersionNumberedFilenameOptionNowBoolean.rst:56 Reply

    Done

    SilentConfigurationUpgradeService.php:1127 Reply

    added a test for this
  15. core-ci voted on patch set 7 V -1 02/10/23, 21:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37588

  16. core-ci voted on patch set 6 V -1 02/10/23, 21:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37587

  17. core-ci voted on patch set 8 V -1 02/10/23, 22:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37589

  18. Benni Mack uploaded patch set 9 V -1 02/11/23, 09:43

  19. core-ci voted on patch set 9 V +1 02/11/23, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37604

  20. Oli Bartsch uploaded patch set 10 V +1 02/11/23, 12:20

  21. Oli Bartsch voted on patch set 10 V +1 CR +1 02/11/23, 12:20

  22. core-ci voted on patch set 10 V +1 02/11/23, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37606

  23. Josef Glatz voted on patch set 10 CR +1 02/12/23, 21:59

  24. Georg Ringer voted on patch set 10 V +2 CR +2 02/13/23, 06:18

  25. Georg Ringer merged patch set 11 02/13/23, 06:18