Review main Merged

77674[TASK] Add Stringable interface for various button components

Benni Mack CR +2 V +2 Normal +28 −32 updated 02/03/23, 08:56

Commit message

This change implements __toString() in various
Toolbar Buttons, so it can be used
in various templates and controllers and is now compatible
with \Stringable. Custom Buttons can implement Stringable for
v12.0 only, and will still be compatible with v11+12

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 914

  1. Benni Mack uploaded patch set 1 02/02/23, 22:16

  2. core-ci voted on patch set 1 V -1 02/02/23, 22:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36941

  3. Benni Mack uploaded patch set 2 V -1 02/02/23, 23:09

  4. Benni Mack uploaded patch set 3 02/02/23, 23:13

  5. core-ci voted on patch set 2 V -1 02/02/23, 23:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36945

  6. core-ci voted on patch set 3 V -1 02/02/23, 23:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36946

  7. Benjamin Kott uploaded patch set 4 V -1 02/03/23, 08:10

  8. core-ci voted on patch set 4 V +1 02/03/23, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36962

  9. Benni Mack uploaded patch set 5 V +1 02/03/23, 08:19

  10. core-ci voted on patch set 5 V +1 02/03/23, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36964

  11. Benjamin Kott voted on patch set 5 V +1 CR +1 02/03/23, 08:37

  12. Andreas Kienast voted on patch set 5 V +1 CR +1 02/03/23, 08:41

  13. Andreas Kienast voted on patch set 5 V +2 CR +2 02/03/23, 08:56

  14. Andreas Kienast merged patch set 6 02/03/23, 08:56