77675[FEATURE] Introduce new PSR-14 BeforeRedirectMatchDomainEvent
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Guido Schmechel +1
-
Verified V +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Guido Schmechel +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-99803-NewPSR-14BeforeRedirectMatchDomainEvent.rst7new+108 −0
- typo3/sysext/redirects/Classes/Event/BeforeRedirectMatchDomainEvent.php2new+86 −0
- typo3/sysext/redirects/Classes/Service/RedirectService.php3+19 −20
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/BeforeRedirectMatchDomainEventIsTriggered.csvnew+3 −0
- typo3/sysext/redirects/Tests/Functional/Service/IntegrityServiceTest.php+2 −0
- typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php+66 −1
- typo3/sysext/redirects/Tests/Unit/Event/BeforeRedirectMatchDomainEventTest.phpnew+53 −0
- typo3/sysext/redirects/Tests/Unit/Service/RedirectServiceTest.php+3 −2
Review log 3850
Show 1925 earlier messages
-
Stefan Bürk uploaded patch set 1 02/02/23, 22:39
-
core-ci voted on patch set 1 V +1 02/02/23, 22:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36942
-
Andreas Steiner wrote 02/03/23, 10:09
Removed cc Andreas Steiner. -
Georg Ringer voted on patch set 1 V +1 CR +1 02/03/23, 10:23
-
Stefan Froemken commented on patch set 1 CR -1 02/03/23, 10:53
Feature-99803-NewPSR-14BeforeRedirectMatchDomainEvent.rst:51spaceFeature-99803-NewPSR-14BeforeRedirectMatchDomainEvent.rst:52TYPO3 CGL: "Inline comments must precede the commented line"BeforeRedirectMatchDomainEvent.php:893 spaces => 1 space should be enough -
Stefan Bürk uploaded patch set 2
CR +1V +102/03/23, 11:25 -
Stefan Bürk commented on patch set 2 02/03/23, 11:25
Feature-99803-NewPSR-14BeforeRedirectMatchDomainEvent.rst:51ReplyDoneFeature-99803-NewPSR-14BeforeRedirectMatchDomainEvent.rst:52ReplyDoneBeforeRedirectMatchDomainEvent.php:89ReplyDone -
core-ci voted on patch set 2 V +1 02/03/23, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36979
-
Stefan Froemken voted on patch set 2 CR +1 02/03/23, 12:26
-
Stefan Bürk commented on patch set 3
CR +1V +102/05/23, 19:55Published edit on patch set 2. -
core-ci voted on patch set 3 V +1 02/05/23, 20:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37127
-
Benni Mack commented on patch set 3 02/05/23, 23:12
Feature-99803-NewPSR-14BeforeRedirectMatchDomainEvent.rst:16what does "matching making" mean? -
Stefan Bürk uploaded patch set 4
V +102/06/23, 05:00 -
Stefan Bürk commented on patch set 3 02/06/23, 05:01
Feature-99803-NewPSR-14BeforeRedirectMatchDomainEvent.rst:16Replygerman and missing sleep. anyway, sentence did not made much sense, and was a duplicat from the one before. Changed the phrasing a little bit. -
core-ci voted on patch set 4 V +1 02/06/23, 05:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37139
-
Lina Wolf commented on patch set 4 CR -1 02/06/23, 14:28
Working on the changelog entry, please do not override me -
Lina Wolf uploaded patch set 5
CR -1V +102/06/23, 14:36 -
Lina Wolf commented on patch set 5 V +1 CR +1 02/06/23, 14:38
I reviewed and corrected the changelog entry, it renders without problems now and the included php lints. The code looks ok to me but someone else must decide on that part. -
core-ci voted on patch set 5 V +1 02/06/23, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37171
-
Stefan Froemken voted on patch set 5 CR +1 02/08/23, 07:13
-
Benni Mack commented on patch set 6
CR +1V +102/08/23, 07:48Published edit on patch set 5. -
core-ci voted on patch set 6 V +1 02/08/23, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37326
-
Stefan Froemken voted on patch set 6 CR +1 02/09/23, 10:08
-
Stefan Bürk voted on patch set 6 CR -1 02/09/23, 20:24
-
Stefan Bürk uploaded patch set 7
CR +1V +102/23/23, 10:35
-
core-ci voted on patch set 7 V +1 02/23/23, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38004
-
Andreas Kienast commented on patch set 7 02/25/23, 14:49
Feature-99803-NewPSR-14BeforeRedirectMatchDomainEvent.rst:34"this [is] not available", but what does that mean?RedirectService.php:72IMO we don't need named arguments here. -
Sybille Peters commented on patch set 7 02/25/23, 15:19
> This can be used to implement matching making which are not generic useful or following rare and special requirements. suggestion: "This can be used to implement matches which are not to be applied in general for rare and special requirements." (not sure if I understood intention 100%)Feature-99803-NewPSR-14BeforeRedirectMatchDomainEvent.rst:44Add :caption: with the file name -
Sybille Peters uploaded patch set 8
V +102/25/23, 15:21 -
Sybille Peters commented on patch set 8 CR +1 02/25/23, 15:22
Feature-99803-NewPSR-14BeforeRedirectMatchDomainEvent.rst:44ReplyDone -
core-ci voted on patch set 8 V +1 02/25/23, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38102
-
Stefan Bürk uploaded patch set 9
CR +1V +102/26/23, 15:48 -
Stefan Bürk commented on patch set 9 02/26/23, 15:48
Reply
Changed.Feature-99803-NewPSR-14BeforeRedirectMatchDomainEvent.rst:34ReplyYeah, missed during rewrite. Anyway, changed the wording/sentance and hope it is now clearer what is meant.RedirectService.php:72ReplyIn the the end, there would never be a real use-case where it would be needed as there is always a way doing it without it (generally). It does not harm it anyway, and it make it kind of more readable and helps in IDE's, also this is not a real hard required argument. I leave it for now as it is, as there is no general rule when and when not yet. If this would be a code part for a backport, I would have omitted in the first place. But it's only for PHP8.1 and there for okay to use this. Or what speaks against using named arguments ? -
core-ci voted on patch set 9 V +1 02/26/23, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38121
-
Sybille Peters commented on patch set 9 CR +1 02/26/23, 16:31
Reply
Done -
Stefan Bürk uploaded patch set 10
CR +1V +103/17/23, 06:11 -
Stefan Bürk commented on patch set 10 03/17/23, 06:12
Feature-99803-NewPSR-14BeforeRedirectMatchDomainEvent.rst:34ReplyDoneRedirectService.php:72ReplyRemoved named arguments for now until final decision. -
core-ci voted on patch set 10 V +1 03/17/23, 06:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39097
-
Stefan Froemken commented on patch set 10 CR -1 03/17/23, 11:44
Feature-99803-NewPSR-14BeforeRedirectMatchDomainEvent.rst:80This table does not exists -
Stefan Froemken uploaded patch set 11
CR -1V +103/17/23, 12:14 -
Stefan Froemken commented on patch set 11 03/17/23, 12:16
Feature-99803-NewPSR-14BeforeRedirectMatchDomainEvent.rst:80ReplyDone -
Stefan Froemken commented on patch set 11 V +1 CR +1 03/17/23, 12:18
Patch is OK. Maybe it would be good to add a note, that the return value of the EventListener should be a valid sys_redirect record with an UID. Later on in the TYPO3 source the UID will be used for X-Redirect-By header. So, don't just return an half-filled array with source, target and status and hope that it will work. Nope...it will not! -
core-ci voted on patch set 11 V +1 03/17/23, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39122
-
Stefan Bürk uploaded patch set 12
CR +1V +103/18/23, 10:58 -
Stefan Bürk commented on patch set 12 03/18/23, 10:59
Reply
Done. Added some remarks in the rest file, docblock for the event getter and setter. -
core-ci voted on patch set 12 V +1 03/18/23, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39183
-
Guido Schmechel voted on patch set 12 V +1 CR +1 03/20/23, 21:00
-
Georg Ringer voted on patch set 12 V +1 CR +1 03/20/23, 21:11
-
Stefan Bürk voted on patch set 12 V +2 CR +2 03/21/23, 01:42
-
Stefan Bürk merged patch set 13 03/21/23, 01:42