Review main Merged

77680[FEATURE] Streamline Template Buttons

Benjamin Kott CR +2 V +2 Hard +493 −254 updated 02/06/23, 09:40

Commit message

This patch streamlines the behavior of template buttons. For this, we
sort all classes to match the same order. To be more flexible for the
usage of `DropDownButton` we now also allow the hiding of the label
text, but there must be a label text or an icon assigned.

We are introducing a `GenericButton` to cover more complex situations
while ensuring a unified output.

Adjust the `typo3-copy-to-clipboard` element to work like a normal
button element that allows keyboard navigation.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 22

Show 2 more files

Review log 1826

Show 1 earlier messages
  1. Benjamin Kott uploaded patch set 1 02/03/23, 13:19

  1. Benjamin Kott uploaded patch set 2 02/03/23, 13:31

  2. core-ci voted on patch set 1 V -1 02/03/23, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36985

  3. Andreas Kienast commented on patch set 2 CR -1 02/03/23, 13:44

    GenericButton.php:151

    Please set the second argument to `true` to avoid potential XSS.
  4. core-ci voted on patch set 2 V -1 02/03/23, 13:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36986

  5. Oliver Klee commented on patch set 2 02/03/23, 15:22

    Typo: tempate -> template Also, there should be a comma after "this".
  6. Andreas Kienast uploaded patch set 3 CR -1 V -1 02/05/23, 12:33

  7. Andreas Kienast commented on patch set 3 02/05/23, 12:34

    Reply

    Done

    GenericButton.php:151 Reply

    Done
  8. Andreas Kienast uploaded patch set 4 02/05/23, 12:36

  9. core-ci voted on patch set 4 V -1 02/05/23, 13:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37107

  10. core-ci voted on patch set 3 V -1 02/05/23, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37106

  11. Andreas Kienast uploaded patch set 5 V -1 02/05/23, 13:18

  12. core-ci voted on patch set 5 V -1 02/05/23, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37109

  13. Oliver Klee wrote 02/05/23, 13:36

    Removed cc Oliver Klee.
  14. Andreas Kienast uploaded patch set 6 V -1 02/05/23, 14:33

  15. core-ci voted on patch set 6 V -1 02/05/23, 14:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37113

  16. Andreas Kienast uploaded patch set 7 V -1 02/05/23, 14:59

  17. core-ci voted on patch set 7 V +1 02/05/23, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37117

  18. Georg Ringer commented on patch set 7 V +1 CR +1 02/05/23, 19:55

    should we change that to a feature as of GenericButton and add an rst?
  19. Benni Mack voted on patch set 7 CR +1 02/05/23, 23:10

  20. Andreas Kienast commented on patch set 7 CR -1 02/06/23, 08:45

    on it
  21. Andreas Kienast uploaded patch set 8 CR +1 V +1 02/06/23, 08:50

  22. core-ci voted on patch set 8 V +1 02/06/23, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37144

  23. Andreas Kienast voted on patch set 8 V +1 CR +1 02/06/23, 09:14

  24. Georg Ringer voted on patch set 8 V +2 CR +2 02/06/23, 09:40

  25. Georg Ringer merged patch set 9 02/06/23, 09:40