77680[FEATURE] Streamline Template Buttons
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Andreas Kienast +1
-
Verified V +2 Done
- Georg Ringer +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 22
- Build/Sources/TypeScript/backend/copy-to-clipboard.ts+17 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/Action/HelpButton.php+0 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/Action/ShortcutButton.php+46 −66
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/AbstractDropDownItem.php+1 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDownButton.php+22 −4
- typo3/sysext/backend/Classes/Template/Components/Buttons/GenericButton.php2new+171 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/InputButton.php+7 −9
- typo3/sysext/backend/Classes/Template/Components/Buttons/LinkButton.php+5 −6
- typo3/sysext/backend/Resources/Public/JavaScript/copy-to-clipboard.js+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/MfaConfigurationControllerTest.php+1 −1
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordList.html+11 −7
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListCopyToClipboard.html+43 −45
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTable.html+8 −6
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTableCopyToClipboard.html+49 −44
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifier.html+11 −7
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArguments.html+11 −7
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArgumentsCopyToClipboard.html+50 −43
- typo3/sysext/beuser/Classes/Controller/PermissionController.php+2 −1
- typo3/sysext/core/Documentation/Changelog/12.2/Feature-99806-IntroduceGenericButtonComponent.rstnew+32 −0
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileClipboardCest.php+2 −2
Review log 1826
Show 1 earlier messages
-
Benjamin Kott uploaded patch set 1 02/03/23, 13:19
-
Benjamin Kott uploaded patch set 2 02/03/23, 13:31
-
core-ci voted on patch set 1 V -1 02/03/23, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36985
-
Andreas Kienast commented on patch set 2 CR -1 02/03/23, 13:44
-
core-ci voted on patch set 2 V -1 02/03/23, 13:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36986
-
Oliver Klee commented on patch set 2 02/03/23, 15:22
Typo: tempate -> template Also, there should be a comma after "this". -
Andreas Kienast uploaded patch set 3
CR -1V -102/05/23, 12:33 -
Andreas Kienast commented on patch set 3 02/05/23, 12:34
Reply
DoneGenericButton.php:151ReplyDone -
Andreas Kienast uploaded patch set 4 02/05/23, 12:36
-
core-ci voted on patch set 4 V -1 02/05/23, 13:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37107
-
core-ci voted on patch set 3 V -1 02/05/23, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37106
-
Andreas Kienast uploaded patch set 5
V -102/05/23, 13:18 -
core-ci voted on patch set 5 V -1 02/05/23, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37109
-
Oliver Klee wrote 02/05/23, 13:36
Removed cc Oliver Klee. -
Andreas Kienast uploaded patch set 6
V -102/05/23, 14:33 -
core-ci voted on patch set 6 V -1 02/05/23, 14:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37113
-
Andreas Kienast uploaded patch set 7
V -102/05/23, 14:59 -
core-ci voted on patch set 7 V +1 02/05/23, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37117
-
Georg Ringer commented on patch set 7 V +1 CR +1 02/05/23, 19:55
should we change that to a feature as of GenericButton and add an rst? -
Benni Mack voted on patch set 7 CR +1 02/05/23, 23:10
-
Andreas Kienast commented on patch set 7 CR -1 02/06/23, 08:45
on it -
Andreas Kienast uploaded patch set 8
CR +1V +102/06/23, 08:50 -
core-ci voted on patch set 8 V +1 02/06/23, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37144
-
Andreas Kienast voted on patch set 8 V +1 CR +1 02/06/23, 09:14
-
Georg Ringer voted on patch set 8 V +2 CR +2 02/06/23, 09:40
-
Georg Ringer merged patch set 9 02/06/23, 09:40
GenericButton.php:151