Review main Merged

77692[TASK] Migrate deprecated PHPUnit 9 methods

Nikita Hovratov CR +2 V +2 Normal +32 −31 updated 02/04/23, 10:29

Commit message

Since the recent release of PHPUnit 9.6 some new deprecations were added
which signal breaking changes for version 10. As deprecations are
causing our tests to fail, they need to be addressed immediately.

Method `expectErrorMessage` replaced with `expectExceptionMessage`.
Method `getMockClass` replaced with `createMock` and a subsequent
get_class call.

Also update phpunit/phpunit to latest version:
> composer update phpunit/phpunit
> composer bump phpunit/phpunit

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 810

  1. Nikita Hovratov uploaded patch set 1 02/04/23, 03:41

  2. core-ci voted on patch set 1 V +1 02/04/23, 03:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37029

  3. Nikita Hovratov uploaded patch set 2 V +1 02/04/23, 04:02

  4. core-ci voted on patch set 2 V +1 02/04/23, 04:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37032

  5. Benjamin Franzke commented on patch set 2 V +1 CR +1 02/04/23, 05:55

    CommandRegistryTest.php:67

    With the improvement above, this could not simply be: self::assertSame($command1Mock, $commandRegistry->get('test:command')); but both checks are fine for now.
  6. Stefan Bürk voted on patch set 2 V +1 CR +1 02/04/23, 07:32

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 02/04/23, 08:11

  8. Oliver Klee voted on patch set 2 V +1 CR +1 02/04/23, 09:28

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 02/04/23, 10:29

  10. Christian Kuhn merged patch set 3 02/04/23, 10:29