Review 11.5 Merged

77693[TASK] Migrate deprecated PHPUnit 9 methods

Nikita Hovratov CR +2 V +2 Hard +155 −167 updated 02/04/23, 10:30

Commit message

Since the recent release of PHPUnit 9.6 some new deprecations were added
which signal breaking changes for version 10. As deprecations are
causing our tests to fail, they need to be addressed immediately.

Method `expectErrorMessage` replaced with `expectExceptionMessage`.
Method `getMockClass` replaced with `createMock` and a subsequent
get_class call.
Move test with deprecations to UnitDeprecated and remove expectation.

Also update phpunit/phpunit and dependencies to latest version:
> composer req --dev phpunit/phpunit:^9.6.1 -W

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 11

Review log 58

  1. Nikita Hovratov uploaded patch set 1 02/04/23, 03:54

  2. core-ci voted on patch set 1 V +1 02/04/23, 04:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37030

  3. Nikita Hovratov uploaded patch set 2 V +1 02/04/23, 04:17

  4. core-ci voted on patch set 2 V -1 02/04/23, 04:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37035

  5. Christian Kuhn uploaded patch set 3 V -1 02/04/23, 10:16

  6. core-ci voted on patch set 3 V +1 02/04/23, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37039

  7. Christian Kuhn voted on patch set 3 V +2 CR +2 02/04/23, 10:30

  8. Christian Kuhn merged patch set 4 02/04/23, 10:30