Review main Merged

77695[TASK] Performance improvement in 'Active TypoScript'

Christian Kuhn CR +2 V +2 Easy +17 −3 updated 02/04/23, 15:17

Commit message

Since #99782, we're always rendering the entire
TypoScript tree. With bigger trees like a loaded
bootstrap_package, these can be thousands of nodes.

One bummer is the f:be.link VH call for each node.
The patch suppresses this with a pretty straight
hack, improving server side by about 40%.

Another optimization (accessing object members)
requires a change in Typo3Fluid, which needs to
be prepared and released on this side first.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Jasmina Ließmann +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Jasmina Ließmann +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 79

  1. Christian Kuhn uploaded patch set 1 02/04/23, 09:06

  2. core-ci voted on patch set 1 V +1 02/04/23, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37038

  3. Christian Kuhn updated the commit message in patch set 2 V +1 02/04/23, 14:25

  4. core-ci voted on patch set 2 V +1 02/04/23, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37052

  5. Jasmina Ließmann voted on patch set 2 V +1 CR +1 02/04/23, 14:49

  6. Anja Leichsenring voted on patch set 2 V +1 CR +1 02/04/23, 15:07

  7. Anja Leichsenring voted on patch set 2 V +2 CR +2 02/04/23, 15:07

  8. Anja Leichsenring merged patch set 3 02/04/23, 15:10

  9. Stefan Bürk voted on patch set 3 V +1 CR +1 02/04/23, 15:17