Review main Merged

77704[TASK] Update various low-level PHP dependencies

Benni Mack CR +2 V +2 Normal +99 −118 updated 02/04/23, 23:08

Commit message

Various dependencies which have released
major versions (to be compatible to further
upstream packages) are now raised:

* doctrine/annotations (allowing both 1.13 + 2)
* doctrine/event-manager (For DBAL v4 compatibility)
* doctrine/lexer (v2 + v3 instead of v1)
* egulias/email-validator (4.0) using lexer

Core `TYPO3\CMS\Core\Database\Schema\Parser\Parser`
has got proper native types and return types to
match deprecated array access on tokens returned
by raised `doctrine/lexer` - which is used internal.
That solved some phpstan ignore patterns as side-change.

Used commands:
* composer req "doctrine/annotations:^1.13.3 || ^2.0" "doctrine/event-manager:^2.0" "doctrine/lexer:^2.0 || ^3.0" "egulias/email-validator:^4.0" -W
* composer req "doctrine/annotations:^1.13.3 || ^2.0" "doctrine/event-manager:^2.0" "doctrine/lexer:^2.0 || ^3.0" "egulias/email-validator:^4.0" -W -d typo3/sysext/core --no-update
* Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1522

  1. Benni Mack uploaded patch set 1 02/04/23, 20:16

  2. core-ci voted on patch set 1 V -1 02/04/23, 20:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37067

  3. Stefan Bürk commented on patch set 1 CR -1 02/04/23, 21:40

    on it ...
  4. Stefan Bürk uploaded patch set 2 CR -1 V -1 02/04/23, 22:05

  5. Stefan Bürk uploaded patch set 3 02/04/23, 22:09

  6. core-ci voted on patch set 3 V +1 02/04/23, 22:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37076

  7. Stefan Bürk uploaded patch set 4 V +1 02/04/23, 22:19

  8. Stefan Bürk updated the commit message in patch set 5 02/04/23, 22:20

  9. core-ci voted on patch set 4 V +1 02/04/23, 22:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37077

  10. core-ci voted on patch set 5 V +1 02/04/23, 22:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37078

  11. Benni Mack updated the commit message in patch set 6 V +1 02/04/23, 22:34

  12. Benni Mack voted on patch set 6 V +1 CR +1 02/04/23, 22:34

  13. Benni Mack updated the commit message in patch set 7 CR +1 V +1 02/04/23, 22:34

  14. Benni Mack voted on patch set 7 V +1 CR +1 02/04/23, 22:35

  15. Stefan Bürk updated the commit message in patch set 8 CR +1 V +1 02/04/23, 22:35

  16. Stefan Bürk voted on patch set 8 V +1 CR +1 02/04/23, 22:35

  17. core-ci voted on patch set 7 V +1 02/04/23, 22:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37080

  18. Jochen Roth voted on patch set 8 V +1 CR +1 02/04/23, 22:46

  19. core-ci voted on patch set 8 V +1 02/04/23, 22:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37081

  20. core-ci voted on patch set 6 V +1 02/04/23, 22:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37079

  21. Stefan Bürk voted on patch set 8 V +2 CR +2 02/04/23, 23:08

  22. Stefan Bürk merged patch set 9 02/04/23, 23:08