77705[BUGFIX] Remove `doctrine/annotations` autoloader registration
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
- Andreas Kienast +1
-
Verified V +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 3
Files 1
Review log 1523
-
Stefan Bürk uploaded patch set 1 02/05/23, 01:48
-
Stefan Bürk uploaded patch set 2 02/05/23, 01:49
-
Stefan Bürk uploaded patch set 3 02/05/23, 01:54
-
Stefan Bürk uploaded patch set 4 02/05/23, 01:54
-
core-ci voted on patch set 2 V -1 02/05/23, 01:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37090
-
core-ci voted on patch set 1 V -1 02/05/23, 01:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37089
-
core-ci voted on patch set 4 V +1 02/05/23, 02:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37092
-
core-ci voted on patch set 3 V -1 02/05/23, 02:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37091
-
Stefan Bürk uploaded patch set 5
V +102/05/23, 02:18 -
core-ci voted on patch set 5 V +1 02/05/23, 02:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37094
-
Stefan Bürk updated the commit message in patch set 6
V +102/05/23, 02:25 -
core-ci voted on patch set 6 V +1 02/05/23, 02:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37095
-
Stefan Bürk commented on patch set 6 02/05/23, 02:34
Running nightly on it to check if it gets fixed: https://git.typo3.org/typo3/CI/cms/-/pipelines/37096 -
core-ci commented on patch set 6 02/05/23, 03:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37096
-
Andreas Kienast commented on patch set 6 02/05/23, 12:44
Won't this break installations where doctrine/annotations v1 are still used? -
Stefan Bürk commented on patch set 6 02/05/23, 13:25
Reply
doctrine/annotations has been raised ot v2+v3 (dual version) constraint in a recenetly patch - and us the reason for failing nightly because of this. See: #99832 -
Nikita Hovratov updated the commit message in patch set 7
V +102/05/23, 13:28 -
core-ci voted on patch set 7 V +1 02/05/23, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37110
-
Nikita Hovratov voted on patch set 7 V +1 CR +1 02/05/23, 13:35
-
Stefan Bürk commented on patch set 7 02/05/23, 13:46
Reply
My bad, answer was before the first coffee. v1 (1.13.x) already deprecated these AnnotationRegistry autoloading methods, recommending to use global autoloader. Thus it *should* be safe. v2 removed them. First played with the option to have a method check here and do it conditionally. But that's not really needed I would say. The v2/v3 was about the lexer in the other patch, take my appologize for the first wrong answer. -
Andreas Kienast commented on patch set 7 V +1 CR +1 02/05/23, 14:14
Reply
Ack -
Stefan Bürk voted on patch set 7 V +2 CR +2 02/05/23, 17:53
-
Stefan Bürk merged patch set 8 02/05/23, 17:53