77707[TASK] Streamline setup command
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Andreas Kienast +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1013
-
Jochen Roth uploaded patch set 1 02/05/23, 20:24
-
core-ci voted on patch set 1 V -1 02/05/23, 21:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37132
-
Jochen Roth uploaded patch set 2
V -102/05/23, 21:55 -
core-ci voted on patch set 2 V -1 02/05/23, 23:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37133
-
Jochen Roth uploaded patch set 3
V -102/06/23, 07:40 -
core-ci voted on patch set 3 V +1 02/06/23, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37141
-
Andreas Kienast commented on patch set 3 CR -1 02/06/23, 14:06
-
Christian Kuhn commented on patch set 3 02/06/23, 15:08
Feature-99221-AddCliInstallSetupCommand.rst:55Replywith zsh, the command is till there if you use 'up' key, but if you call `history` and the command has been prefixed with a whitespace, it's not there. that't what we meant. confirmed? can not tset myselfs, since i'm using bash, but that's what jochen just showed me. -
Andreas Kienast commented on patch set 3 CR 0 02/06/23, 15:16
Feature-99221-AddCliInstallSetupCommand.rst:55ReplyExactly. With pressing "up" I receive the command but it's not persisted in the history. Comment is invalid. -
Andreas Kienast commented on patch set 3 CR +1 02/06/23, 15:29
SetupCommand.php:172nice catch! -
Christian Kuhn commented on patch set 3 V +1 CR +1 02/06/23, 15:36
SetupCommand.php:172ReplyAck -
Stefan Bürk voted on patch set 3 V +2 CR +2 02/06/23, 15:39
-
Stefan Bürk merged patch set 4 02/06/23, 15:39
Feature-99221-AddCliInstallSetupCommand.rst:55