Review main Merged

77707[TASK] Streamline setup command

Jochen Roth CR +2 V +2 Normal +94 −83 updated 02/06/23, 15:39

Commit message

Additional warning about password set via cli has been
added. Also the logic was changed to always prompt
for password (db password and admin user password) if
not set via variable/option.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1013

  1. Jochen Roth uploaded patch set 1 02/05/23, 20:24

  2. core-ci voted on patch set 1 V -1 02/05/23, 21:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37132

  3. Jochen Roth uploaded patch set 2 V -1 02/05/23, 21:55

  4. core-ci voted on patch set 2 V -1 02/05/23, 23:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37133

  5. Jochen Roth uploaded patch set 3 V -1 02/06/23, 07:40

  6. core-ci voted on patch set 3 V +1 02/06/23, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37141

  7. Andreas Kienast commented on patch set 3 CR -1 02/06/23, 14:06

    Feature-99221-AddCliInstallSetupCommand.rst:55

    Just tested this with zsh and that's not the case for me. Perhaps I miss a configuration or oh-my-zsh overrides something. IMO we're safe to drop this hint as it's apparently not always correct.
  8. Christian Kuhn commented on patch set 3 02/06/23, 15:08

    Feature-99221-AddCliInstallSetupCommand.rst:55 Reply

    with zsh, the command is till there if you use 'up' key, but if you call `history` and the command has been prefixed with a whitespace, it's not there. that't what we meant. confirmed? can not tset myselfs, since i'm using bash, but that's what jochen just showed me.
  9. Andreas Kienast commented on patch set 3 CR 0 02/06/23, 15:16

    Feature-99221-AddCliInstallSetupCommand.rst:55 Reply

    Exactly. With pressing "up" I receive the command but it's not persisted in the history. Comment is invalid.
  10. Andreas Kienast commented on patch set 3 CR +1 02/06/23, 15:29

    SetupCommand.php:172

    nice catch!
  11. Christian Kuhn commented on patch set 3 V +1 CR +1 02/06/23, 15:36

    SetupCommand.php:172 Reply

    Ack
  12. Stefan Bürk voted on patch set 3 V +2 CR +2 02/06/23, 15:39

  13. Stefan Bürk merged patch set 4 02/06/23, 15:39