Review main Abandoned

77708[FEATURE] Support stdWrap.if for config.showWebsiteTitle

Sebastian Klein CR 0 V 0 Easy +45 −1 updated 02/07/23, 16:54

Commit message

The TypoScript function "if." (checkIf) can now be used
on "config.showWebsiteTitle" to influence the rendering
of the website title in the title tag.

Example:

  config.showWebsiteTitle = 0
  config.showWebsiteTitle.if.isTrue.data = page:seo_title

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 45

  1. Sebastian Klein uploaded patch set 1 02/06/23, 06:40

  2. core-ci voted on patch set 1 V +1 02/06/23, 06:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37140

  3. Nikita Hovratov commented on patch set 1 V -1 02/06/23, 21:03

    Hey Sebastian, unfortunately stdWrap on the top config TypoScript option does not work on fully cached pages, as the cObj is not available. The Tests only worked because of a current bug. We already reverted another similar patch for config.additionalHeaders.
  4. Sebastian Klein abandoned the change 02/07/23, 06:15

    Abandoned because of issue with fully cached pages
  5. Sebastian Klein commented on patch set 1 02/07/23, 16:54

    Reply

    Hi Nikita, thank you for the clarification. I will then abandon this patch and might check a different approach at a later time.