Review main Merged Breaking

77709[!!!][TASK] Require doctrine/dbal 4.x

Stefan Bürk CR +2 V +2 Nightmare +4024 −2393 updated 01/24/24, 14:11

Commit message

TYPO3 v13 requires Doctrine DBAL 4 and will be subsequently updated.

Doctrine DBAL 4 is shipping with a few breaking changes, where
most breaking stuff is coped and handled by the TYPO3 core and placed
in internal API implementation and wrappings. However, minor breaking
things on extended and provided API's are included and requires proper
adoption by extensions.

* [1] `AbstractPlatform::getName()` has been removed and `instance of`
  checks are required to be used instead. TYPO3 adopted this removal
  in the extended platform classes and does not provide a b/c for it.

* [2] Doctrine DBAL dropped support for older RDBMS version, aligned
  the Platform class extend chain and removed not-supported version
  for PostgreSQL and MariaDB. TYPO3 extended platform implementation
  are aligned and platform replacement in the replacement driver
  middleware modified.

* [3] Doctrine DBAL switched the casing (renaming) of some
  of the Platform classes, where the new casing has already been
  used for the extended classes. Due to the fact that aliased
  `use` import statement has been used, adjusting these casing
  is minimized to these places.

* [4] `Connection::lastInsertId()` no longer accepts a sequence
  name. TYPO3 core `Connection::getLastInsertId()` implementation
  is aligned to match this and core usages has been replaced with
  a pre-patch except one oversight which is done now.

* [5] Doctrine DBAL introducing replacement methods for the removed
  methods `QueryBuilder::resetQueryParam()` and `resetQueryParams()`,
  which are replaced at required places. Methods are removed on TYPO3
  QueryBuilder to be aligned with Doctrine DBAL.

* [6] Doctrine DBAL made QueryBuilder's state internal and therefore
  removed the QueryBuilder methods `getQueryParts()`, `getQueryPart()`,
  `getType()` and `getState()` along with the public class constants.
  Methods are removed from the TYPO3 QueryBuilder to align here with
  Doctrine DBAL. TYPO3 requires access to this internal state, mainly
  for the Extbase ORM handling and the ContentObjectRenderer. This is
  solved by introducing a internal `ConcreteQueryBuilder` ensuring a
  state duplication and adding internal marked public getter to the
  outer TYPO3 QueryBuilder.

* [7] Doctrine DBAL removed schema compare APIs not taking the
  DB connection into account and suggest to use connection aware
  comparator instead. `TYPO3\CMS\Install\Database\PermissionsCheck`
  is modified to respect this change.

* [8] Doctrine DBAL removed table renaming by using the `TableDiff`
  object and not creating corresponding DDL statements anymore. To
  compensate for this, the already extended `TableDiff` object get
  the `new name` information reintroduced, and the renaming SQL DDL
  is directly created at the required place in `ConnectionMigrator`.

* [9] Deprecated `SchemaDiff::toSql()` and `toSaveSql()` are replaced
  with `AbstractPlatform::getAlterSchemaSQL()`.

* [10] TYPO3 SchemaMigrator, ConnectionMigrator and Comparator are
  modified to cope with some modifications in Doctrine DBAL 4.
  This leads to the requirement that additional normalisation from the
  MySQL variant (ext_tables.sql) towards the target platform. SQLite
  autoincrement normalization is moved from SchemaMigrator into the
  connection migrator and additional MySQL/MariaDB, generic identifier
  and PostgreSQL normalization is added to cope with this fact.

* [11] Due to dropped PostgreSQL 9.6 support Doctrine DBAL switched
  from `SERIAL` to `GENERATED IDENTITY COLUMN` as virtual autoincrement
  handling still using sequence tables under the hood. The implemented
  schema change created by Doctrine DBAL will not migrate the sequence
  relation correctly and leads to really bad issues. The suggested and
  documented way is to create and use a procedure to migrate this. This
  is not suitable for the TYPO3 way of doing the database changes, and
  the `ConnectionMigrator` is modified to create the update statements
  taken from the procedure and replacing the normal alter statements.
  Due to the lack of a good entry point to combine data migration with
  required DDL changes, this has been implemented as a hackish merged
  statement for the meanwhile.

* \TYPO3\CMS\Core\Database\Platform\PlatformSaveAlterSchemaSQLTrait is
  removed as "not used anymore" and already mitigated.

The required work on the database analyser involved classes revealed
badly, that a complete overhaul and restructuring of the code in this
area is mandatory but exceeds the scope if this change. Multiple todo
comments have been added to make this clear and will be done later. This
is possible because the code in this area is considerable internal versus
the need to make the breaking change until the dot-zero sprint release.

Used command(s):

> \
  composer req --no-update --no-install \
    -d typo3/sysext/redirects \
    "doctrine/dbal":"4.0.x-dev@dev" ; \
  composer req --no-update --no-install \
    -d typo3/sysext/core \
    "doctrine/dbal":"4.0.x-dev@dev" ; \
  composer req --no-update --no-install \
    -d typo3/sysext/install \
    "doctrine/dbal":"4.0.x-dev@dev" ; \
  composer req -W \
    "doctrine/dbal":"4.0.x-dev@dev" ; \
  COMPOSER=composer.dist.json composer req --no-update \
    -d Build/composer \
    "doctrine/dbal":"4.0.x-dev@dev"

>  Build/Scripts/runTests.sh -s phpstanGenerateBaseline

[1]  https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-doctrinedbaldrivergetname-removed
     https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-removed-support-for-postgresql-93-and-older
[2]  https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-removed-support-for-mariadb-100-and-older
     https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-removed-support-for-mysql-56-and-older
[3]  https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-renamed-sqlite-platform-classes
[4]  https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#removed-support-for-connectionlastinsertidname
[5]  https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#deprecated-reset-methods-from-querybuilder
[6]  https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#deprecated-getting-query-parts-from-querybuilder
     https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#deprecated-querybuilder-methods-and-constants
[7]  https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-removed-schema-comparison-apis-that-dont-account-for-the-current-database-connection-and-the-database-platform
[8]  https://github.com/doctrine/dbal/blob/3.7.x/UPGRADE.md#deprecated-renaming-tables-via-tablediff-and-abstractplatformaltertable
[9]  https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#deprecated-schemadifftosql-and-schemadifftosavesql
[10] https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-changes-in-handling-string-and-binary-columns
[11] https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-auto-increment-columns-on-postgresql-are-implemented-as-identity-not-serial
     https://github.com/doctrine/dbal/blob/4.0.x/docs/en/how-to/postgresql-identity-migration.rst

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 108

Show 88 more files

Review log 116234

Show 99209 earlier messages
  1. Stefan Bürk uploaded patch set 1 02/06/23, 10:03

  2. core-ci voted on patch set 1 V -1 02/06/23, 10:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37147

  3. Stefan Bürk uploaded patch set 2 V -1 02/06/23, 10:11

  4. core-ci voted on patch set 2 V -1 02/06/23, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37148

  5. Stefan Bürk uploaded patch set 3 V -1 02/12/23, 18:44

  6. core-ci voted on patch set 3 V -1 02/12/23, 19:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37622

  7. Stefan Bürk uploaded patch set 4 V -1 02/14/23, 21:37

  8. core-ci voted on patch set 4 V -1 02/14/23, 22:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37715

  9. Stefan Bürk uploaded patch set 5 V -1 03/07/23, 06:54

  10. core-ci voted on patch set 5 V -1 03/07/23, 06:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38575

  11. Stefan Bürk uploaded patch set 6 V -1 03/18/23, 18:56

  12. core-ci voted on patch set 6 V -1 03/18/23, 20:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39190

  13. Stefan Bürk uploaded patch set 7 V -1 03/18/23, 20:38

  14. core-ci voted on patch set 7 V -1 03/18/23, 21:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39192

  15. Stefan Bürk uploaded patch set 8 V -1 03/18/23, 22:28

  16. Stefan Bürk uploaded patch set 9 03/18/23, 22:38

  17. core-ci voted on patch set 8 V -1 03/18/23, 23:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39193

  18. core-ci voted on patch set 9 V -1 03/18/23, 23:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39194

  19. Stefan Bürk uploaded patch set 10 V -1 09/29/23, 10:50

  20. Stefan Bürk updated the commit message in patch set 11 09/29/23, 10:52

  21. core-ci voted on patch set 10 V -1 09/29/23, 11:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47298

  22. core-ci voted on patch set 11 V -1 09/29/23, 11:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47299

  23. Stefan Bürk uploaded patch set 12 V -1 09/29/23, 14:53

  24. core-ci voted on patch set 12 V -1 09/29/23, 15:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47309

  25. Stefan Bürk uploaded patch set 13 V -1 10/05/23, 09:26

  26. core-ci voted on patch set 13 V -1 10/05/23, 09:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47431

  27. Stefan Bürk uploaded patch set 14 V -1 10/06/23, 12:26

  28. Stefan Bürk uploaded patch set 15 10/06/23, 12:30

  29. core-ci voted on patch set 14 V -1 10/06/23, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47487

  30. core-ci voted on patch set 15 V -1 10/06/23, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47488

  31. Stefan Bürk uploaded patch set 16 V -1 10/10/23, 07:59

  32. Stefan Bürk uploaded patch set 17 10/10/23, 08:03

  33. core-ci voted on patch set 16 V -1 10/10/23, 08:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47641

  34. Oliver Klee commented on patch set 17 10/10/23, 08:13

  35. core-ci voted on patch set 17 V -1 10/10/23, 08:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47642

  36. Stefan Bürk uploaded patch set 18 V -1 10/10/23, 10:30

  37. core-ci voted on patch set 18 V -1 10/10/23, 10:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47649

  38. Stefan Bürk uploaded patch set 19 V -1 10/10/23, 19:48

  39. core-ci voted on patch set 19 V -1 10/10/23, 19:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47662

  40. Stefan Bürk uploaded patch set 20 V -1 10/11/23, 11:40

  41. core-ci voted on patch set 20 V -1 10/11/23, 11:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47675

  42. Stefan Bürk uploaded patch set 21 V -1 10/11/23, 12:03

  43. core-ci voted on patch set 21 V -1 10/11/23, 12:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47680

  44. Stefan Bürk uploaded patch set 22 V -1 10/11/23, 13:21

  45. core-ci voted on patch set 22 V -1 10/11/23, 13:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47683

  46. Stefan Bürk uploaded patch set 23 V -1 10/11/23, 21:43

  47. core-ci voted on patch set 23 V -1 10/11/23, 21:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47694

  48. Stefan Bürk uploaded patch set 24 V -1 10/12/23, 08:42

  49. core-ci voted on patch set 24 V -1 10/12/23, 08:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47705

  50. Oliver Klee commented on patch set 24 10/12/23, 09:07

    Reply

    Done
  51. Stefan Bürk uploaded patch set 25 V -1 10/12/23, 16:56

  52. core-ci voted on patch set 25 V -1 10/12/23, 17:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47729

  53. Stefan Bürk uploaded patch set 26 V -1 10/13/23, 12:43

  54. core-ci voted on patch set 26 V -1 10/13/23, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47737

  55. Stefan Bürk uploaded patch set 27 V -1 10/13/23, 13:32

  56. Stefan Bürk uploaded patch set 28 10/13/23, 13:40

  57. core-ci voted on patch set 27 V -1 10/13/23, 13:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47739

  58. core-ci voted on patch set 28 V -1 10/13/23, 13:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47740

  59. Stefan Bürk uploaded patch set 29 V -1 10/13/23, 14:32

  60. core-ci voted on patch set 29 V -1 10/13/23, 14:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47742

  61. Stefan Bürk uploaded patch set 30 V -1 10/14/23, 19:56

  62. core-ci voted on patch set 30 V -1 10/14/23, 20:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47763

  63. Stefan Bürk uploaded patch set 31 V -1 10/18/23, 14:54

  64. core-ci voted on patch set 31 V -1 10/18/23, 15:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47913

  65. Stefan Bürk uploaded patch set 32 V -1 10/20/23, 12:54

  66. core-ci voted on patch set 32 V -1 10/20/23, 13:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47975

  67. Stefan Bürk uploaded patch set 33 V -1 10/26/23, 12:01

  68. core-ci voted on patch set 33 V -1 10/26/23, 12:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48232

  69. Stefan Bürk uploaded patch set 34 V -1 11/17/23, 10:15

  70. core-ci voted on patch set 34 V -1 11/17/23, 10:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49055

  71. Stefan Bürk uploaded patch set 35 V -1 11/17/23, 18:30

  72. core-ci voted on patch set 35 V -1 11/17/23, 18:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49073

  73. Stefan Bürk rebased onto patch set 36 V -1 11/19/23, 18:47

  74. core-ci voted on patch set 36 V -1 11/19/23, 18:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49104

  75. Stefan Bürk uploaded patch set 37 V -1 11/19/23, 21:21

  76. core-ci voted on patch set 37 V -1 11/19/23, 21:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49106

  77. Stefan Bürk uploaded patch set 38 V -1 01/09/24, 15:14

  78. core-ci voted on patch set 38 V -1 01/09/24, 15:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51342

  79. Stefan Bürk uploaded patch set 39 V -1 01/10/24, 02:52

  80. core-ci voted on patch set 39 V -1 01/10/24, 02:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51370

  81. Stefan Bürk updated the commit message in patch set 40 V -1 01/10/24, 02:59

  82. core-ci voted on patch set 40 V -1 01/10/24, 03:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51371

  83. Stefan Bürk uploaded patch set 41 V -1 01/10/24, 10:04

  84. core-ci voted on patch set 41 V -1 01/10/24, 10:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51378

  85. Stefan Bürk uploaded patch set 42 V -1 01/10/24, 12:28

  86. core-ci voted on patch set 42 V -1 01/10/24, 12:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51384

  87. Stefan Bürk uploaded patch set 43 V -1 01/10/24, 12:31

  88. core-ci voted on patch set 43 V -1 01/10/24, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51385

  89. Stefan Bürk uploaded patch set 44 V -1 01/10/24, 20:22

  90. core-ci voted on patch set 44 V -1 01/10/24, 20:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51403

  91. Stefan Bürk uploaded patch set 45 V -1 01/10/24, 20:24

  92. core-ci voted on patch set 45 V -1 01/10/24, 20:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51404

  93. Stefan Bürk uploaded patch set 46 V -1 01/11/24, 11:30

  94. core-ci voted on patch set 46 V -1 01/11/24, 11:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51436

  95. Stefan Bürk uploaded patch set 47 V -1 01/11/24, 14:38

  96. core-ci voted on patch set 47 V -1 01/11/24, 14:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51446

  97. Stefan Bürk uploaded patch set 48 V -1 01/12/24, 13:33

  98. core-ci voted on patch set 48 V -1 01/12/24, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51504

  99. Stefan Bürk uploaded patch set 49 V -1 01/12/24, 13:40

  100. core-ci voted on patch set 49 V -1 01/12/24, 13:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51505

  101. Stefan Bürk uploaded patch set 50 V -1 01/12/24, 19:31

  102. core-ci voted on patch set 50 V -1 01/12/24, 19:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51515

  103. Stefan Bürk uploaded patch set 51 V -1 01/12/24, 21:31

  104. core-ci voted on patch set 51 V -1 01/12/24, 21:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51518

  105. Stefan Bürk uploaded patch set 52 V -1 01/12/24, 21:37

  106. core-ci voted on patch set 52 V -1 01/12/24, 21:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51519

  107. Stefan Bürk uploaded patch set 53 V -1 01/12/24, 21:58

  108. core-ci voted on patch set 53 V -1 01/12/24, 22:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51520

  109. Stefan Bürk uploaded patch set 54 V -1 01/12/24, 22:05

  110. core-ci voted on patch set 54 V -1 01/12/24, 22:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51522

  111. Stefan Bürk uploaded patch set 55 V -1 01/12/24, 22:24

  112. Stefan Bürk updated the commit message in patch set 56 01/12/24, 22:24

  113. core-ci voted on patch set 55 V -1 01/12/24, 22:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51523

  114. core-ci voted on patch set 56 V -1 01/12/24, 22:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51524

  115. Stefan Bürk uploaded patch set 57 V -1 01/12/24, 23:21

  116. core-ci voted on patch set 57 V -1 01/12/24, 23:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51525

  117. Stefan Bürk uploaded patch set 58 V -1 01/12/24, 23:29

  118. core-ci voted on patch set 58 V +1 01/12/24, 23:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51526

  119. Stefan Bürk updated the commit message in patch set 59 V +1 01/12/24, 23:44

  120. core-ci voted on patch set 59 V +1 01/12/24, 23:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51529

  121. Stefan Bürk uploaded patch set 60 V +1 01/15/24, 17:32

  122. core-ci voted on patch set 60 V +1 01/15/24, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51597

  123. Stefan Bürk uploaded patch set 61 V +1 01/15/24, 18:25

  124. core-ci voted on patch set 61 V -1 01/15/24, 18:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51599

  125. Stefan Bürk uploaded patch set 62 V -1 01/15/24, 18:43

  126. core-ci voted on patch set 62 V -1 01/15/24, 18:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51601

  127. Stefan Bürk uploaded patch set 63 V -1 01/15/24, 19:35

  128. core-ci voted on patch set 63 V +1 01/15/24, 19:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51602

  129. core-ci voted on patch set 63 V -1 01/15/24, 19:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51605

  130. Stefan Bürk uploaded patch set 64 V -1 01/16/24, 14:35

  131. core-ci voted on patch set 64 V +1 01/16/24, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51647

  132. Stefan Bürk uploaded patch set 65 V +1 01/16/24, 22:26

  133. core-ci voted on patch set 65 V -1 01/16/24, 22:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51664

  134. Stefan Bürk uploaded patch set 66 V -1 01/16/24, 23:49

  135. core-ci voted on patch set 66 V -1 01/16/24, 23:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51665

  136. Stefan Bürk uploaded patch set 67 V -1 01/17/24, 01:07

  137. core-ci voted on patch set 67 V -1 01/17/24, 01:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51667

  138. Stefan Bürk uploaded patch set 68 V -1 01/17/24, 01:25

  139. core-ci voted on patch set 68 V +1 01/17/24, 01:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51668

  140. Stefan Bürk updated the commit message in patch set 69 V +1 01/17/24, 01:38

  141. core-ci voted on patch set 69 V +1 01/17/24, 01:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51669

  142. Stefan Bürk uploaded patch set 70 V +1 01/17/24, 14:10

  143. Stefan Bürk uploaded patch set 71 01/17/24, 14:13

  144. core-ci voted on patch set 70 V -1 01/17/24, 14:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51689

  145. core-ci voted on patch set 71 V -1 01/17/24, 14:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51690

  146. Stefan Bürk uploaded patch set 72 V -1 01/17/24, 16:36

  147. core-ci voted on patch set 72 V -1 01/17/24, 16:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51701

  148. core-ci commented on patch set 72 01/17/24, 16:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51701

  149. core-ci commented on patch set 72 01/17/24, 16:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51701

  150. Stefan Bürk uploaded patch set 73 V -1 01/17/24, 18:03

  151. core-ci voted on patch set 73 V -1 01/17/24, 18:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51705

  152. core-ci commented on patch set 73 01/17/24, 18:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51705

  153. core-ci commented on patch set 73 01/17/24, 18:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51705

  154. Stefan Bürk uploaded patch set 74 V -1 01/17/24, 18:36

  155. core-ci voted on patch set 74 V +1 01/17/24, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51709

  156. Stefan Bürk uploaded patch set 75 V +1 01/19/24, 09:38

  157. core-ci voted on patch set 75 V -1 01/19/24, 09:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51793

  158. Stefan Bürk uploaded patch set 76 V -1 01/19/24, 09:57

  159. core-ci voted on patch set 76 V -1 01/19/24, 10:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51796

  160. Stefan Bürk uploaded patch set 77 V -1 01/19/24, 10:41

  161. core-ci voted on patch set 77 V +1 01/19/24, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51802

  162. core-ci voted on patch set 77 V -1 01/19/24, 11:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51805

  163. core-ci commented on patch set 77 01/19/24, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51805

  164. core-ci commented on patch set 77 01/19/24, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51805

  165. Stefan Bürk uploaded patch set 78 V -1 01/19/24, 17:24

  166. core-ci voted on patch set 78 V -1 01/19/24, 17:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51825

  167. Stefan Bürk updated the commit message in patch set 79 V -1 01/19/24, 17:43

  168. core-ci voted on patch set 79 V -1 01/19/24, 17:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51826

  169. Stefan Bürk uploaded patch set 80 V -1 01/19/24, 18:15

  170. core-ci voted on patch set 80 V +1 01/19/24, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51827

  171. core-ci voted on patch set 80 V -1 01/19/24, 18:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51829

  172. Stefan Bürk uploaded patch set 81 V -1 01/20/24, 15:05

  173. core-ci voted on patch set 81 V +1 01/20/24, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51843

  174. Stefan Bürk uploaded patch set 82 V +1 01/20/24, 16:56

  175. core-ci voted on patch set 82 V +1 01/20/24, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51849

  176. core-ci commented on patch set 82 01/20/24, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51850

  177. Stefan Bürk uploaded patch set 83 V +1 01/20/24, 17:21

  178. core-ci voted on patch set 83 V +1 01/20/24, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51851

  179. Stefan Bürk uploaded patch set 84 V +1 01/20/24, 19:07

  180. core-ci voted on patch set 84 V +1 01/20/24, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51852

  181. core-ci commented on patch set 84 01/20/24, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51853

  182. Stefan Bürk uploaded patch set 85 V +1 01/20/24, 20:00

  183. core-ci voted on patch set 85 V +1 01/20/24, 20:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51854

  184. Stefan Bürk uploaded patch set 86 V +1 01/20/24, 20:32

  185. core-ci voted on patch set 86 V -1 01/20/24, 20:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51855

  186. Stefan Bürk uploaded patch set 87 V -1 01/20/24, 23:52

  187. core-ci voted on patch set 87 V +1 01/20/24, 23:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51864

  188. core-ci commented on patch set 87 01/21/24, 00:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51865

  189. Stefan Bürk uploaded patch set 88 V +1 01/21/24, 00:26

  190. core-ci voted on patch set 88 V +1 01/21/24, 00:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51866

  191. core-ci commented on patch set 88 01/21/24, 00:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51867

  192. Stefan Bürk uploaded patch set 89 V +1 01/21/24, 01:11

  193. Stefan Bürk uploaded patch set 90 01/21/24, 01:14

  194. core-ci voted on patch set 90 V +1 01/21/24, 01:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51870

  195. core-ci voted on patch set 90 V -1 01/21/24, 01:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51871

  196. Stefan Bürk uploaded patch set 91 V -1 01/21/24, 01:46

  197. core-ci voted on patch set 91 V +1 01/21/24, 01:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51872

  198. core-ci commented on patch set 91 01/21/24, 02:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51874

  199. Stefan Bürk uploaded patch set 92 V +1 01/22/24, 17:32

  200. core-ci voted on patch set 92 V -1 01/22/24, 17:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51946

  201. Stefan Bürk uploaded patch set 93 V -1 01/23/24, 12:16

  202. core-ci voted on patch set 93 V -1 01/23/24, 12:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51993

  203. Stefan Bürk uploaded patch set 94 V -1 01/23/24, 12:36

  204. core-ci voted on patch set 94 V +1 01/23/24, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51994

  205. Stefan Bürk updated the commit message in patch set 95 V +1 01/23/24, 12:42

  206. core-ci voted on patch set 95 V +1 01/23/24, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51995

  207. Stefan Bürk updated the commit message in patch set 96 V +1 01/23/24, 12:53

  208. core-ci voted on patch set 96 V +1 01/23/24, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51996

  209. Benni Mack commented on patch set 96 01/23/24, 16:21

    Breaking-102875-QueryBuilderChanges.rst:22

    this line is here twice

    Breaking-102875-QueryBuilderChanges.rst:25

    this line is here twice

    Important-102875-UpdatedDependencyDoctrineDBAL4.rst:17

    "and provide them in a advanced" - I do not understand this sentence

    Important-102875-UpdatedDependencyDoctrineDBAL4.rst:18

    "minor breaking things" - can you find a different word than "things"?

    Important-102875-UpdatedDependencyDoctrineDBAL4.rst:21

    can you link to the upgrade guides?
  1. Stefan Bürk uploaded patch set 97 V +1 01/23/24, 17:28

  2. Stefan Bürk updated the commit message in patch set 98 01/23/24, 17:29

  3. Stefan Bürk commented on patch set 98 01/23/24, 17:31

    Breaking-102875-QueryBuilderChanges.rst:22 Reply

    Done

    Breaking-102875-QueryBuilderChanges.rst:25 Reply

    Done

    Important-102875-UpdatedDependencyDoctrineDBAL4.rst:17 Reply

    Done

    Important-102875-UpdatedDependencyDoctrineDBAL4.rst:18 Reply

    Done

    Important-102875-UpdatedDependencyDoctrineDBAL4.rst:21 Reply

    Done
  4. core-ci voted on patch set 97 V +1 01/23/24, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52023

  5. core-ci voted on patch set 98 V +1 01/23/24, 17:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52024

  6. Benni Mack updated the commit message in patch set 99 V +1 01/23/24, 20:16

  7. Benni Mack voted on patch set 99 CR +1 V +1 01/23/24, 20:20

  8. core-ci voted on patch set 99 V +1 01/23/24, 20:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52039

  9. Oliver Klee voted on patch set 99 V +1 01/24/24, 08:37

  10. Christian Kuhn commented on patch set 99 CR -1 01/24/24, 10:31

    on it.
  11. Christian Kuhn uploaded patch set 100 CR +1 V +1 01/24/24, 11:34

  12. core-ci voted on patch set 100 V -1 01/24/24, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52069

  13. Christian Kuhn uploaded patch set 101 V -1 01/24/24, 11:58

  14. core-ci voted on patch set 101 V +1 01/24/24, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52071

  15. Christian Kuhn uploaded patch set 102 V +1 01/24/24, 12:08

  16. core-ci voted on patch set 102 V +1 01/24/24, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52074

  17. Christian Kuhn uploaded patch set 103 V +1 01/24/24, 12:21

  18. core-ci voted on patch set 103 V +1 01/24/24, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52075

  19. Christian Kuhn uploaded patch set 104 V +1 01/24/24, 13:02

  20. core-ci voted on patch set 104 V +1 01/24/24, 13:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52079

  21. Christian Kuhn voted on patch set 104 CR +1 V +1 01/24/24, 13:10

  22. Oliver Klee voted on patch set 104 V +1 01/24/24, 13:29

  23. Benni Mack voted on patch set 104 CR +1 V +1 01/24/24, 14:03

  24. Stefan Bürk voted on patch set 104 CR +2 V +2 01/24/24, 14:11

  25. Stefan Bürk merged patch set 105 01/24/24, 14:11