77710[BUGFIX] Apply correct default classes to `GenericButton`
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Benjamin Kott +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Benjamin Kott +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/backend/Classes/Template/Components/Buttons/GenericButton.php3+13 −1
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordList.html+1 −1
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTable.html+1 −1
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifier.html+1 −1
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArguments.html+1 −1
Review log 1113
-
Andreas Kienast uploaded patch set 1 02/06/23, 10:34
-
Andreas Kienast uploaded patch set 2 02/06/23, 10:34
-
core-ci voted on patch set 2 V +1 02/06/23, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37150
-
Benjamin Kott voted on patch set 2 V +1 CR +1 02/06/23, 10:46
-
Oli Bartsch commented on patch set 2 02/06/23, 12:35
-
Andreas Kienast commented on patch set 2 CR -1 02/06/23, 13:20
GenericButton.php:155ReplyFine for me, will adjust the patch -
Andreas Kienast uploaded patch set 3
CR +1V +102/06/23, 13:21 -
Andreas Kienast commented on patch set 3 02/06/23, 13:27
GenericButton.php:155ReplyDone -
core-ci voted on patch set 3 V +1 02/06/23, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37162
-
Benjamin Kott voted on patch set 3 V +1 CR +1 02/06/23, 13:58
-
Oli Bartsch voted on patch set 3 V +1 CR +1 02/06/23, 14:16
-
Andreas Kienast voted on patch set 3 V +2 CR +2 02/06/23, 14:17
-
Andreas Kienast merged patch set 4 02/06/23, 14:17
GenericButton.php:155