Review main Merged

77710[BUGFIX] Apply correct default classes to `GenericButton`

Andreas Kienast CR +2 V +2 Easy +17 −5 updated 02/06/23, 14:17

Commit message

The class `TYPO3\CMS\Backend\Template\Components\Buttons\GenericButton`
accidentally applied the wrong CSS classes on the rendered button.
This bugfix now applies the correct classes for buttons and provides
setter and getter methods for classes.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1113

  1. Andreas Kienast uploaded patch set 1 02/06/23, 10:34

  2. Andreas Kienast uploaded patch set 2 02/06/23, 10:34

  3. core-ci voted on patch set 2 V +1 02/06/23, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37150

  4. Benjamin Kott voted on patch set 2 V +1 CR +1 02/06/23, 10:46

  5. Oli Bartsch commented on patch set 2 02/06/23, 12:35

    GenericButton.php:155

    Could we apply a rtrim() here to prevent the whitespace in case no additional class has been set?
  6. Andreas Kienast commented on patch set 2 CR -1 02/06/23, 13:20

    GenericButton.php:155 Reply

    Fine for me, will adjust the patch
  7. Andreas Kienast uploaded patch set 3 CR +1 V +1 02/06/23, 13:21

  8. Andreas Kienast commented on patch set 3 02/06/23, 13:27

    GenericButton.php:155 Reply

    Done
  9. core-ci voted on patch set 3 V +1 02/06/23, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37162

  10. Benjamin Kott voted on patch set 3 V +1 CR +1 02/06/23, 13:58

  11. Oli Bartsch voted on patch set 3 V +1 CR +1 02/06/23, 14:16

  12. Andreas Kienast voted on patch set 3 V +2 CR +2 02/06/23, 14:17

  13. Andreas Kienast merged patch set 4 02/06/23, 14:17