Review 11.5 Merged

77712[BUGFIX] Enforce validation when no cHash is given

Oliver Hader CR +2 V +2 Hard +335 −3 updated 02/06/23, 16:29

Commit message

When no cHash is given but GET parameters are handed in
which _would_ require cHash parameters, these are now
properly evaluated during the frontend request.

As this has a security impact,
a new option called
$GLOBALS['TYPO3_CONF_VARS']['FE']['cacheHash']['enforceValidation']
is introduced, which then skips
the "requireCacheHashPresenceParameters" option.
The latter is an include list, but cache Hash
calculation should rather be based on
the exclude list such as "excludedParameters" and
"cachedParametersWhiteList".

If the new option is set, but some properties such
as tx_solr[q] should be allowed, then this needs
to be added to the excludedList ("excludedParameters")
by extension authors.

A new test "SlugSiteWithoutRequiredCHashRequestTest"
is added which works with a disabled feature
flag compared to "SlugSiteRequestTest" which
has the feature flag enabled.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 19

Review log 710

  1. Oliver Hader uploaded patch set 1 02/06/23, 14:58

  2. core-ci voted on patch set 1 V -1 02/06/23, 15:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37173

  3. Oliver Hader uploaded patch set 2 V -1 02/06/23, 15:32

  4. Oliver Hader voted on patch set 2 V +1 CR +1 02/06/23, 15:42

  5. core-ci voted on patch set 2 V -1 02/06/23, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37177

  6. Oliver Hader uploaded patch set 3 CR +1 V +1 02/06/23, 15:48

  7. core-ci voted on patch set 3 V +1 02/06/23, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37179

  8. Oliver Hader voted on patch set 3 V +1 CR +1 02/06/23, 16:16

  9. Oliver Hader voted on patch set 3 V +2 CR +2 02/06/23, 16:29

  10. Oliver Hader merged patch set 4 02/06/23, 16:29