Review main Merged

77718[TASK] Raise php-cs-fixer

Benni Mack CR +2 V +2 Normal +51 −51 updated 02/10/23, 15:09

Commit message

Used command:
  composer req --dev "friendsofphp/php-cs-fixer:^3.14.4" -W

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 711

  1. Benni Mack uploaded patch set 1 02/06/23, 17:35

  2. Christian Kuhn commented on patch set 1 02/06/23, 17:59

    maybe / please wait for 3.14.4, which will hopefully be released soon: this will bring a req-change for sebatian/diff which unblocks a phpunit 10 detail.
  3. core-ci voted on patch set 1 V +1 02/06/23, 18:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37193

  4. Benni Mack uploaded patch set 2 V +1 02/10/23, 14:43

  5. Benni Mack updated the commit message in patch set 3 02/10/23, 14:44

  6. Benni Mack uploaded patch set 4 02/10/23, 14:45

  7. core-ci voted on patch set 2 V +1 02/10/23, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37567

  8. core-ci voted on patch set 4 V +1 02/10/23, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37569

  9. core-ci voted on patch set 3 V -1 02/10/23, 15:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37568

  10. Benni Mack voted on patch set 4 V +2 CR +2 02/10/23, 15:09

  11. Benni Mack merged patch set 5 02/10/23, 15:09