Review 11.5 Merged

77720[BUGFIX] Support deferred ConsumerScope in GlobalEventHandler

Nicole Hummel CR +2 V +2 Easy +27 −16 updated 07/10/23, 20:59

Commit message

The GlobalEventHandler changes the location of the current (target)
window. The location is set to a given destination without any ability
to interrupt. The existing ConsumerScope API isn't used even if the
current window is the ContentContainer. This patch extends the handling
of a navigation action by checking its target window and using proper
ContentContainer API to set the location. Therefore registered listener
can deny a location change and trigger own functions.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 57

  1. Nicole Hummel uploaded patch set 1 02/06/23, 17:44

  2. core-ci voted on patch set 1 V +1 02/06/23, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37199

  3. Benni Mack updated the commit message in patch set 2 V +1 05/03/23, 09:30

  4. Benni Mack updated the commit message in patch set 3 05/03/23, 09:30

  5. Benjamin Franzke uploaded patch set 4 07/10/23, 20:49

  6. core-ci voted on patch set 4 V +1 07/10/23, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43993

  7. Benjamin Franzke merged patch set 5 07/10/23, 20:59